Skip to content

[Composer] Conflict with symfony/serializer:^6.4.23 because of a fatal error in APIP 2.7#18195

Merged
NoResponseMate merged 3 commits intoSylius:1.14from
GSadee:SYL-5142-conflict-with-symfony-serializer
Jun 30, 2025
Merged

[Composer] Conflict with symfony/serializer:^6.4.23 because of a fatal error in APIP 2.7#18195
NoResponseMate merged 3 commits intoSylius:1.14from
GSadee:SYL-5142-conflict-with-symfony-serializer

Conversation

@GSadee
Copy link
Copy Markdown
Member

@GSadee GSadee commented Jun 30, 2025

Q A
Branch? 1.14
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes https://github.com/Sylius/Sylius/actions/runs/15961757109/job/45015313493#step:13:11
License MIT

@GSadee GSadee requested a review from a team as a code owner June 30, 2025 10:20
@GSadee GSadee added Dependencies Pull requests that update a dependency file Bug Confirmed bugs or bugfixes. labels Jun 30, 2025
@probot-autolabeler probot-autolabeler bot added the Maintenance CI configurations, READMEs, releases, etc. label Jun 30, 2025
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Jun 30, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 30, 2025 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands:

  • 🚀 /bns:deploy to redeploy the environment

@probot-autolabeler probot-autolabeler bot added the API APIs related issues and PRs. label Jun 30, 2025
@NoResponseMate NoResponseMate merged commit 6c98f66 into Sylius:1.14 Jun 30, 2025
49 of 51 checks passed
@GSadee GSadee deleted the SYL-5142-conflict-with-symfony-serializer branch June 30, 2025 12:40
@Jibbarth Jibbarth mentioned this pull request Aug 14, 2025
Merged
TheMilek added a commit that referenced this pull request Aug 20, 2025
@TheMilek
[Composer][1.14] More specific confflict with serializer (#18302)
ebf70b4 
| Q               | A
|-----------------|-----
| Branch?         | 1.14
| Bug fix?        | no
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | #18195 
| License         | MIT

The bug raised in #18195 as been revert in symfony/serializer in 6.4.24
(cf symfony/symfony#60958)

I guess we can target the conflict only on 6.4.23 now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NoResponseMate NoResponseMate NoResponseMate approved these changes

Assignees

No one assigned

Labels

API APIs related issues and PRs. Bug Confirmed bugs or bugfixes. Dependencies Pull requests that update a dependency file Maintenance CI configurations, READMEs, releases, etc.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GSadee @NoResponseMate