Fixed bug that caused an error: "array_merge(): Argument #2 is not an ar...#1796
Merged
pjedrzejewski merged 1 commit intoSylius:masterfrom Aug 18, 2014
Merged
Fixed bug that caused an error: "array_merge(): Argument #2 is not an ar...#1796pjedrzejewski merged 1 commit intoSylius:masterfrom
pjedrzejewski merged 1 commit intoSylius:masterfrom
Conversation
…not an array" when there is no parameter with keys "criteria" and "sorting"
Contributor
|
👍, but I would say that this should be covered by specs. |
Contributor
|
👍 |
Contributor
Author
|
Sorry guys but I don't know how to write specs. I will learn it and will add to this PR. |
pjedrzejewski
pushed a commit
that referenced
this pull request
Aug 18, 2014
Fixed bug that caused an error: "array_merge(): Argument #2 is not an ar...
Contributor
|
Thanks @sivolobov! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed bug that caused an error: "array_merge(): Argument #2 is not an array" when there is no parameter with keys "criteria" and "sorting".