Skip to content

Fix dev firewall order#17919

Merged
GSadee merged 1 commit intoSylius:1.14from
SVillette:fix-dev-firewall-order
May 6, 2025
Merged

Fix dev firewall order#17919
GSadee merged 1 commit intoSylius:1.14from
SVillette:fix-dev-firewall-order

Conversation

@SVillette
Copy link
Copy Markdown
Contributor

@SVillette SVillette commented Apr 30, 2025

Q A
Branch? 1.14
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets -
License MIT

All requests from /_profiler and /_wdt are currently part of shop firewall instead of dev. It's because the dev firewall is defined in last position and /_profiler and _wdt are not excluded from %sylius.security.shop_regex%.
Defining it first fixes this issue.

However, existing projects should also change their config, should I target 2.1 branch instead and add this change in the UPGRADE-2.1.md ?

@SVillette SVillette requested a review from a team as a code owner April 30, 2025 13:13
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 30, 2025 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 30, 2025 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands:

  • 🚀 /bns:deploy to redeploy the environment

@GSadee GSadee added Maintenance CI configurations, READMEs, releases, etc. Bug Confirmed bugs or bugfixes. DX Issues and PRs aimed at improving Developer eXperience. labels May 5, 2025
@GSadee GSadee force-pushed the fix-dev-firewall-order branch from fdd4795 to 8e015c7 Compare May 5, 2025 13:28
@GSadee
Copy link
Copy Markdown
Member

GSadee commented May 5, 2025

Hello @SVillette, there is no need to add this change to other branches, we will do the upmerge once it is merged. However, this is a config that exists in the end application, it would be good to fix it also in https://github.com/Sylius/Sylius-Standard on 1.14 and 2.0 branches. Would you like to open PRs there?

@SVillette SVillette mentioned this pull request May 5, 2025
Merged
@SVillette
Copy link
Copy Markdown
Contributor Author

SVillette commented May 5, 2025

Hi @GSadee, The PR is done in Sylius/Sylius-Standard#1129. Do you upmerge commits there too ? Or do I need to create a PR on the 2.0 branch ?

@GSadee
Copy link
Copy Markdown
Member

GSadee commented May 6, 2025

Hi @GSadee, The PR is done in Sylius/Sylius-Standard#1129. Do you upmerge commits there too ? Or do I need to create a PR on the 2.0 branch ?

In the Sylius-Standard, there is a need for 2 PRs unfortunately.

@GSadee GSadee merged commit 3471386 into Sylius:1.14 May 6, 2025
27 of 28 checks passed
@SVillette SVillette mentioned this pull request May 6, 2025
Merged
GSadee added a commit to Sylius/Sylius-Standard that referenced this pull request May 8, 2025
@GSadee
Fix dev firewall order (#1129)
9d35f2b 
Follow up of Sylius/Sylius#17919
GSadee added a commit to Sylius/Sylius-Standard that referenced this pull request Jun 9, 2025
@GSadee
Fix dev firewall order (Sylius 2.0) (#1130)
b2ce400 
Follow up of Sylius/Sylius#17919
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GSadee GSadee GSadee approved these changes

Assignees

No one assigned

Labels

Bug Confirmed bugs or bugfixes. DX Issues and PRs aimed at improving Developer eXperience. Maintenance CI configurations, READMEs, releases, etc.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SVillette @GSadee