[Maintenance] Bump Symfony packages to ^7.2#17830
Conversation
WalkthroughThis pull request updates the Symfony version constraints across the project from ^7.1 to ^7.2. The updates affect the GitHub workflow matrix as well as numerous Composer configuration files in the main project, various Sylius bundles, and components. Every occurrence where Symfony version was specified as ^7.1 has been replaced with ^7.2 to ensure consistency in dependency declarations and compatibility across environments. Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (44)
🚧 Files skipped from review as they are similar to previous changes (44)
⏰ Context from checks skipped due to timeout of 90000ms (14)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
❌ Preview Environment deleted from BunnyshellAvailable commands:
|
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (22)
composer.json (3)
89-140: Update Symfony Dependencies in "require" Section
The Symfony package version constraints have been updated to support "^7.2" alongside existing "^6.4" versions. This change is consistent across all listed Symfony components and should help ensure compatibility with Symfony 7.2 features.
228-234: Update Symfony Dependencies in "require-dev" Section
The version constraints for Symfony dev packages such as browser-kit, debug-bundle, dotenv, runtime, and web-profiler-bundle have been bumped to include "^7.2". This maintains consistency with the production dependencies.
260-263: Bump Symfony Requirement in Extra Configuration
The "extra" configuration has been updated to require Symfony "^7.2". This central declaration now aligns with the updated dependency list and reflects the overall upgrade strategy.src/Sylius/Component/Product/composer.json (1)
53-55: Update Symfony Version Requirement in Extra Section
The Symfony version requirement under the "extra" section has been updated to "^7.2". This brings the component in line with the project-wide dependency strategy.src/Sylius/Component/Promotion/composer.json (1)
45-47: Align Symfony Dependency in Promotion Component
The "extra" section for the Promotion component now specifies"require": "^7.2", ensuring consistency across components with the new Symfony version target.src/Sylius/Component/Order/composer.json (1)
46-48: Update Symfony Requirement for Order Component
The Symfony version is now declared as "^7.2" in the "extra" section, which aligns with the overall maintenance update to bump the dependency version.src/Sylius/Component/Review/composer.json (1)
56-58: Synchronize Symfony Version for Review Component
The "extra" section in this component has been updated to require Symfony "^7.2", maintaining consistency with the project-wide upgrade.src/Sylius/Bundle/AttributeBundle/composer.json (3)
34-34: Update Symfony Framework Bundle Version Constraint
The version constraint for"symfony/framework-bundle"has been updated to"^6.4.1 || ^7.2", which now properly includes Symfony 7.2. This aligns with the overall PR objective to support the newer Symfony version.
43-45: Update Symfony Dev Dependencies Version Constraints
The version constraints for"symfony/browser-kit","symfony/dependency-injection", and"symfony/form"have been updated to support Symfony 7.2 (i.e. using"^6.4 || ^7.2"or"^6.4.1 || ^7.2"). This ensures consistency in dependency declarations across the bundle.
61-62: Synchronize Extra Symfony Requirement
The"extra"section now requires"^7.2", ensuring that the overall Symfony version requirement remains consistent with the updated dependency constraints.src/Sylius/Bundle/InventoryBundle/composer.json (3)
32-33: Update Core Symfony Dependencies
The updates for"symfony/framework-bundle"and"symfony/validator"now include support for Symfony 7.2. This change is in line with the PR’s objective of bumping Symfony package versions.
44-45: Update Symfony Dev Dependency Constraints
The version constraints for"symfony/browser-kit"and"symfony/dependency-injection"have been updated to allow Symfony 7.2, ensuring all development dependencies are consistent with the new version requirement.
57-59: Ensure Extra Section Consistency
The"extra"section"symfony": { "require": "^7.2" }confirms that the overall Symfony requirement now aligns with the updated dependencies.src/Sylius/Bundle/CustomerBundle/composer.json (3)
43-43: Update Symfony Framework Bundle Version Constraint
The update for"symfony/framework-bundle"now includes the version constraint"^6.4.1 || ^7.2", which supports Symfony 7.2 and maintains backward compatibility with 6.4.1.
50-52: Update Symfony Dev Dependencies
The changes for"symfony/browser-kit","symfony/dependency-injection", and"symfony/form"(now allowing"^6.4 || ^7.2"and"^6.4.1 || ^7.2") ensure that development tools are aligned with the updated Symfony version.
63-65: Synchronize Extra Section Version Requirement
The"extra"section now specifies"require": "^7.2", which standardizes the Symfony version requirement across the bundle configuration.src/Sylius/Bundle/MoneyBundle/composer.json (3)
30-31: Update Symfony Core Dependency Constraints
The updates for"symfony/framework-bundle"and"symfony/intl"now include support for Symfony 7.2, making the bundle compatible with the latest Symfony release while preserving support for the 6.4 series.
43-45: Update Symfony Dev Dependencies
The version constraints for"symfony/browser-kit","symfony/dependency-injection", and"symfony/form"have been updated to include Symfony 7.2 support. This ensures development dependencies remain in sync with the core dependency versions.
57-59: Synchronize Extra Section Requirement
The"extra"section now mandates"^7.2", ensuring that the overall Symfony version requirement is applied consistently across all configuration sections.src/Sylius/Bundle/TaxationBundle/composer.json (3)
35-36: Update Core Symfony Dependencies
The updates for"symfony/clock"and"symfony/framework-bundle"now support"^6.4 || ^7.2"and"^6.4.1 || ^7.2"respectively, reflecting the shift to support Symfony 7.2.
47-49: Update Symfony Dev Dependencies
The changes for"symfony/browser-kit","symfony/dependency-injection", and"symfony/form"ensure that development tools are compatible with Symfony 7.2, in line with the overall update strategy.
60-62: Synchronize Extra Section Requirement
The"extra"section now requires"^7.2", providing consistency with all other dependency constraints in the project.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (43)
.github/workflows/matrix.json(6 hunks)composer.json(3 hunks)src/Sylius/Abstraction/StateMachine/composer.json(2 hunks)src/Sylius/Bundle/AddressingBundle/composer.json(3 hunks)src/Sylius/Bundle/AdminBundle/composer.json(3 hunks)src/Sylius/Bundle/ApiBundle/composer.json(3 hunks)src/Sylius/Bundle/AttributeBundle/composer.json(3 hunks)src/Sylius/Bundle/ChannelBundle/composer.json(2 hunks)src/Sylius/Bundle/CoreBundle/composer.json(3 hunks)src/Sylius/Bundle/CurrencyBundle/composer.json(3 hunks)src/Sylius/Bundle/CustomerBundle/composer.json(2 hunks)src/Sylius/Bundle/InventoryBundle/composer.json(3 hunks)src/Sylius/Bundle/LocaleBundle/composer.json(3 hunks)src/Sylius/Bundle/MoneyBundle/composer.json(3 hunks)src/Sylius/Bundle/OrderBundle/composer.json(3 hunks)src/Sylius/Bundle/PaymentBundle/composer.json(3 hunks)src/Sylius/Bundle/PayumBundle/composer.json(2 hunks)src/Sylius/Bundle/ProductBundle/composer.json(3 hunks)src/Sylius/Bundle/PromotionBundle/composer.json(3 hunks)src/Sylius/Bundle/ReviewBundle/composer.json(2 hunks)src/Sylius/Bundle/ShippingBundle/composer.json(3 hunks)src/Sylius/Bundle/ShopBundle/composer.json(3 hunks)src/Sylius/Bundle/TaxationBundle/composer.json(3 hunks)src/Sylius/Bundle/TaxonomyBundle/composer.json(2 hunks)src/Sylius/Bundle/UiBundle/composer.json(3 hunks)src/Sylius/Bundle/UserBundle/composer.json(3 hunks)src/Sylius/Component/Addressing/composer.json(2 hunks)src/Sylius/Component/Attribute/composer.json(2 hunks)src/Sylius/Component/Channel/composer.json(2 hunks)src/Sylius/Component/Core/composer.json(2 hunks)src/Sylius/Component/Currency/composer.json(2 hunks)src/Sylius/Component/Customer/composer.json(1 hunks)src/Sylius/Component/Inventory/composer.json(1 hunks)src/Sylius/Component/Locale/composer.json(2 hunks)src/Sylius/Component/Order/composer.json(1 hunks)src/Sylius/Component/Payment/composer.json(2 hunks)src/Sylius/Component/Product/composer.json(1 hunks)src/Sylius/Component/Promotion/composer.json(1 hunks)src/Sylius/Component/Review/composer.json(1 hunks)src/Sylius/Component/Shipping/composer.json(2 hunks)src/Sylius/Component/Taxation/composer.json(2 hunks)src/Sylius/Component/Taxonomy/composer.json(1 hunks)src/Sylius/Component/User/composer.json(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (14)
- GitHub Check: End-to-end tests (MariaDB) / Non-JS, PHP 8.3, Symfony ^7.2, MariaDB 11.4.3, State Machine Adapter winzou_state_machine
- GitHub Check: End-to-end tests (MariaDB) / Non-JS, PHP 8.3, Symfony ^7.2, MariaDB 11.4.3, State Machine Adapter symfony_workflow
- GitHub Check: End-to-end tests (MariaDB) / Non-JS, PHP 8.2, Symfony ^6.4, MariaDB 10.11.9, State Machine Adapter symfony_workflow
- GitHub Check: End-to-end tests (MySQL) / JS with Panther, PHP 8.3, Symfony ^7.2 (test_cached), MySQL 8.4, Twig ^3.3
- GitHub Check: End-to-end tests (MySQL) / JS with Panther, PHP 8.2, Symfony ^6.4 (test_cached), MySQL 8.0, Twig ^3.3
- GitHub Check: End-to-end tests (MySQL) / JS with Chromedriver, PHP 8.3, Symfony ^7.2 (test_cached), MySQL 8.4, Twig ^3.3
- GitHub Check: End-to-end tests (MySQL) / Non-JS, PHP 8.3, Symfony ^7.2 (test_cached), MySQL 8.4, Twig ^3.3
- GitHub Check: End-to-end tests (MySQL) / JS with Chromedriver, PHP 8.2, Symfony ^6.4 (test_cached), MySQL 8.0, Twig ^3.3
- GitHub Check: End-to-end tests (MySQL) / Non-JS, PHP 8.2, Symfony ^6.4 (test_cached), MySQL 8.0, Twig ^3.3
- GitHub Check: End-to-end tests (PostgreSQL) / Non-JS, PHP 8.3, Symfony ^7.2, PostgreSQL 16.4
- GitHub Check: End-to-end tests (PostgreSQL) / Non-JS, PHP 8.2, Symfony ^6.4, PostgreSQL 15.8
- GitHub Check: Packages / PHP 8.3, Symfony ^7.2
- GitHub Check: Packages / PHP 8.2, Symfony ^6.4
- GitHub Check: Frontend / NodeJS 20.x
🔇 Additional comments (79)
src/Sylius/Component/Inventory/composer.json (1)
46-47: Symfony Version Requirement Bumped in Extra Section
The"symfony"requirement in the"extra"block has been updated from^7.1to^7.2, which aligns perfectly with the project's upgrade objectives. Please ensure that any tooling or scripts that depended on the previous version constraint are reviewed for compatibility.src/Sylius/Component/Customer/composer.json (1)
52-53: Consistent Symfony Version Update
The Symfony version under the"extra"section has been updated to^7.2, in line with the other components. This change is consistent and clear.src/Sylius/Component/Taxonomy/composer.json (1)
47-48: Symfony Dependency Constraint Updated
The"symfony"requirement within the"extra"section is now^7.2, ensuring that this component aligns with the new dependency standards of the project..github/workflows/matrix.json (1)
10-13: CI Matrix Symfony Versions Upgraded
Throughout the CI configuration in the matrix file, all entries specifying Symfony version have been updated to include^7.2(typically replacing or appending to previous constraints like^6.4). This update affects multiple testing environments (e.g., static checks, e2e tests for MariaDB, MySQL, and PostgreSQL, as well as package testing). Please verify that all CI jobs and testing environments are fully compatible with Symfony 7.2 to avoid unexpected integration issues.Also applies to: 25-27, 48-51, 63-67, 80-86, 90-94, 96-100, 110-114, 116-120, 128-130
src/Sylius/Bundle/AddressingBundle/composer.json (1)
33-34: Symfony Version Constraints Refined in AddressingBundle
The version constraints for Symfony packages (such as"symfony/framework-bundle","symfony/intl", and others in the"require-dev"section) have been updated to use^7.2(in combination with the existing^6.4.xwhere applicable). In the"extra"section, the Symfony requirement is also updated to^7.2. These changes ensure uniform dependency declarations across the project.Also applies to: 63-65
src/Sylius/Component/Locale/composer.json (2)
32-32: Updated symfony/intl Dependency Version
The version constraint for"symfony/intl"has been updated to"^6.4 || ^7.2", which aligns this component with Symfony 7.2. This change is clear and consistent with the overall upgrade plan.
46-48: Updated Symfony Extra Requirement
In the"extra"section, the Symfony requirement has been bumped to"^7.2", ensuring consistency with the dependency update and the project-wide initiative.src/Sylius/Component/Payment/composer.json (2)
33-33: Updated symfony/uid Dependency Version
The version constraint for"symfony/uid"is now"^6.4 || ^7.2", supporting the newer Symfony version and keeping in line with the broader upgrade.
47-49: Updated Symfony Extra Requirement
The"symfony"requirement in the"extra"section has been updated to"^7.2", which makes this component’s configuration consistent with the project's new Symfony version.src/Sylius/Component/User/composer.json (2)
40-40: Updated symfony/security-core Dependency Version
The dependency"symfony/security-core"now uses the version constraint"^6.4 || ^7.2", ensuring compatibility with Symfony 7.2 and matching the upgrade across other components.
59-61: Updated Symfony Extra Requirement
The Symfony requirement under the"extra"section has been revised to"^7.2", aligning it with the updated dependencies and the project’s overall upgrade strategy.src/Sylius/Component/Currency/composer.json (2)
31-31: Updated symfony/intl Dependency Version
The"symfony/intl"dependency’s version constraint now reads"^6.4 || ^7.2", which is in line with the changes across the codebase to support Symfony 7.2.
45-47: Updated Symfony Extra Requirement
The"extra"section now requires Symfony"^7.2", ensuring that the configuration stays consistent with the dependency updates and overall project compatibility goals.src/Sylius/Component/Taxation/composer.json (2)
34-34: Updated symfony/clock Dependency Version
The"symfony/clock"dependency has been bumped to"^6.4 || ^7.2", reflecting the project's commitment to upgrade to Symfony 7.2 and providing clear support for the newer version.
48-50: Updated Symfony Extra Requirement
The"extra"section now specifies"^7.2"for Symfony, maintaining consistency with the dependency changes and the overall upgrade strategy for the project.src/Sylius/Component/Addressing/composer.json (2)
32-32: Updated Dependency Constraint for Symfony/intl
The version constraint for"symfony/intl"has been updated to^6.4 || ^7.2. This correctly reflects the intended upgrade from Symfony 7.1 to 7.2 and ensures compatibility with both 6.4 and 7.2 versions.
47-47: Updated Symfony Requirement in Extra Section
The"require": "^7.2"setting within the"symfony"extra section is in line with the project’s upgrade objective. This change ensures that users of this package will be subject to the new Symfony version constraint.src/Sylius/Component/Attribute/composer.json (2)
32-32: Updated Symfony/validator Version Constraint
The dependency"symfony/validator"has been updated from^6.4 || ^7.1to^6.4 || ^7.2, which aligns with the new Symfony version and maintains backward compatibility with 6.4.
47-47: Consistent Symfony Version Requirement in Extra Section
The update from"require": "^7.1"to"require": "^7.2"in the extra section is consistent with the overall upgrade goal. Ensure that this change is documented in the relevant upgrade notes for clarity.src/Sylius/Component/Shipping/composer.json (2)
34-34: Updated Symfony/options-resolver Dependency
The version constraint for"symfony/options-resolver"has been changed to^6.4 || ^7.2, properly reflecting the shift to Symfony 7.2 while still supporting 6.4.
48-49: Adjusted Symfony Requirement in Extra Section
The extra section’s"require": "^7.2"now correctly aligns with our dependency upgrade. This ensures that the component will be used with Symfony 7.2 or higher, matching the PR objectives.src/Sylius/Bundle/PayumBundle/composer.json (2)
46-46: Revised Symfony/dependency-injection Version Constraint
The updated constraint for"symfony/dependency-injection"in the"require-dev"section now includes support for Symfony 7.2. This change is essential for maintaining consistency across development dependencies.
57-58: Consistent Update in the Extra Section
The Symfony requirement in the extra section has been updated from^7.1to^7.2, which is now uniform with the other package updates.src/Sylius/Component/Channel/composer.json (2)
33-34: Updated Symfony/Form and Symfony/HTTP-Foundation Constraints
The upgrade of"symfony/form"to^6.4.1 || ^7.2and"symfony/http-foundation"to^6.4 || ^7.2ensures that these dependencies are now aligned with Symfony 7.2 requirements while still allowing support for earlier 6.4 versions where applicable.
49-49: Extra Section Symfony Version Update
Changing the extra section to"require": "^7.2"maintains consistency across the project's components. This update helps enforce the new minimum Symfony version throughout the package usage.src/Sylius/Component/Core/composer.json (4)
55-57: Update Symfony Dependencies in "require" Section
The version constraints forsymfony/http-client,symfony/http-foundation, andsymfony/mimehave been updated from supporting^6.4 || ^7.1to^6.4 || ^7.2. This change is consistent with the PR’s goal of upgrading Symfony to ^7.2.
59-59: Ensure Consistency forsymfony/stringDependency
The update to"^6.4 || ^7.2"forsymfony/stringaligns with the upgrade strategy.
66-66: Update require-dev Dependency forsymfony/property-access
Updating the version constraint to"^6.4 || ^7.2"ensures that the developer tools remain consistent with Symfony 7.2 compatibility.
68-68: Bump Symfony Requirement in Extra Section
Changing the Symfony version requirement from^7.1to^7.2in theextrasection guarantees overall alignment with the upgraded Symfony ecosystem.src/Sylius/Bundle/ShopBundle/composer.json (3)
35-36: Upgrade Symfony Framework and Security Bundles
The version constraints forsymfony/framework-bundleandsymfony/security-bundlehave been updated to support^7.2. This update ensures that the storefront bundle benefits from the latest features and security improvements in Symfony 7.2.
50-50: Update Dependency Injection in require-dev
The update to"symfony/dependency-injection": "^6.4.1 || ^7.2"brings the dependency injection tooling in line with the new Symfony version.
62-62: Bump Symfony Version in Extra Section
Updating"symfony": { "require": "^7.2" }in theextrasection standardizes the overall Symfony version requirement across the bundle.src/Sylius/Bundle/AdminBundle/composer.json (3)
40-40: Update Symfony Framework Bundle
symfony/framework-bundleis now constrained to^6.4.1 || ^7.2, ensuring that the admin panel remains compatible with Symfony 7.2 without breaking backward compatibility with 6.4.
55-56: Upgrade Dependency Injection and Dotenv Components
Bothsymfony/dependency-injectionandsymfony/dotenvhave been updated to support Symfony 7.2. This is a necessary step to ensure that the admin bundle uses current best practices in dependency management and environment configuration.
68-68: Standardize Symfony Version Requirement in Extra Section
Updating the"require"in the extra section to"^7.2"aligns all Symfony dependencies within the admin bundle with the overall project upgrade.src/Sylius/Bundle/ApiBundle/composer.json (3)
33-33: Upgrade Symfony Messenger Component
The version constraint forsymfony/messengerhas been updated to"^6.4 || ^7.2", which fits the overall upgrade objective toward Symfony 7.2.
44-46: Update Browser Kit, Debug, and Dotenv Dependencies
The dependencies forsymfony/browser-kit,symfony/debug-bundle, andsymfony/dotenvnow support"^6.4 || ^7.2", ensuring that these development and debugging tools are compatible with the new Symfony version.
62-64: Harmonize Symfony Requirement in the Extra Section
The update to"require": "^7.2"in the extra section ensures that the API bundle’s overall Symfony version requirement is consistent with the upgraded dependencies.src/Sylius/Abstraction/StateMachine/composer.json (2)
24-26: Update Symfony Dependencies for State Machine Abstraction
The version constraints forsymfony/dependency-injection,symfony/http-kernel, andsymfony/workflowhave been revised to support"^6.4.1 || ^7.2"or"^6.4 || ^7.2". This update ensures that the state machine abstraction layer is fully compatible with Symfony 7.2 while retaining support for Symfony 6.4.
43-44: Bump Symfony Version Requirement in Extra Section
The update in the extra section to require"^7.2"consolidates the compatibility of this component with the latest Symfony version.src/Sylius/Bundle/TaxonomyBundle/composer.json (3)
35-35: Upgrade Symfony Framework-Bundle Constraint
The dependency has been updated to"^6.4.1 || ^7.2", which aligns with the new Symfony 7.2 support while still allowing the 6.4.x series.
42-42: Upgrade Symfony Dependency-Injection (require-dev)
The version constraint for"symfony/dependency-injection"has been updated to"^6.4.1 || ^7.2", ensuring consistency across development dependencies.
54-55: Synchronize Extra Symfony Requirement
The extra configuration now specifies"require": "^7.2", making sure that the overall Symfony version requirement is in sync with the updated dependencies.src/Sylius/Bundle/PaymentBundle/composer.json (2)
44-45: Refine Symfony Dependencies in "require-dev"
The updates to"symfony/browser-kit"and"symfony/dependency-injection"now include"^7.2". Please verify that these changes integrate smoothly with your development and test tools.
56-57: Align Extra Symfony Version Requirement
The extra section now requires Symfony"^7.2", ensuring consistency across the dependency configuration.src/Sylius/Bundle/LocaleBundle/composer.json (3)
34-34: Upgrade Framework-Bundle Version Constraint
The dependency"symfony/framework-bundle"has been updated to"^6.4.1 || ^7.2", aligning the bundle with the Symfony 7.2 update.
45-46: Synchronize Development Dependencies
Both"symfony/browser-kit"and"symfony/dependency-injection"in the require-dev section have been upgraded to support Symfony"^7.2". Confirm that these changes work well with your testing framework.
58-59: Update Extra Symfony Requirement
The extra configuration now demands Symfony"^7.2", providing consistency with the other dependency constraints.src/Sylius/Bundle/OrderBundle/composer.json (3)
35-35: Update Framework-Bundle Version Constraint
The version for"symfony/framework-bundle"has been updated to"^6.4.1 || ^7.2", ensuring compatibility with Symfony 7.2 while retaining support for 6.4.1.
47-49: Update Development Dependencies for Symfony Components
The changes for"symfony/browser-kit","symfony/form", and"symfony/validator"now include"^7.2". Please verify that these updates are fully compatible within your tests and local environment.
57-57: Synchronize Extra Requirement
The extra section now requires Symfony"^7.2", which is consistent with the overall upgrade strategy.src/Sylius/Bundle/ChannelBundle/composer.json (3)
31-31: Update Framework-Bundle Constraint
The"symfony/framework-bundle"dependency has been revised to"^6.4.1 || ^7.2"to reflect support for Symfony 7.2.
39-41: Upgrade Development Dependencies
The require-dev block now updates"symfony/browser-kit","symfony/dependency-injection", and"symfony/form"to include Symfony"^7.2". Ensure these changes are adequately tested in your CI pipeline.
57-58: Harmonize Extra Symfony Version Requirement
The extra configuration has been updated to require Symfony"^7.2", ensuring alignment with the dependency updates.src/Sylius/Bundle/UserBundle/composer.json (3)
46-47: Update Symfony Dependency Constraints.
The version constraints for bothsymfony/framework-bundleandsymfony/password-hasherhave been updated to allow^7.2(in addition to the existing^6.4ranges). This is consistent with the overall update objective.
56-58: Update Development Dependency Constraints.
The updates forsymfony/dependency-injection,symfony/mailer, andsymfony/security-bundlenow support^7.2. The modifications are consistent and correctly applied.
73-73: Update Extra Symfony Requirement.
Theextra.symfony.requirevalue has been bumped from^7.1to^7.2, aligning the bundle with the latest Symfony dependency updates.src/Sylius/Bundle/CurrencyBundle/composer.json (3)
31-32: Update Core Symfony Dependencies.
The dependency constraints forsymfony/framework-bundleandsymfony/intlnow allow^7.2alongside the current^6.4versions, which aligns with the maintenance update.
43-45: Update Development Dependencies for Symfony Components.
The version constraints forsymfony/browser-kit,symfony/dependency-injection, andsymfony/formhave been updated to include^7.2. These changes are coherent with the project's upgrade goals.
58-58: Synchronize Extra Symfony Constraint.
The Symfony requirement in theextrasection is now set to^7.2, ensuring consistency with the rest of the package's dependency updates.src/Sylius/Bundle/ProductBundle/composer.json (3)
35-35: Update Framework Bundle Constraint.
The constraint forsymfony/framework-bundlehas been updated to"^6.4.1 || ^7.2", which is in line with the overall version bump to Symfony 7.2.
44-47: Adjust Dev Dependencies for Symfony Components.
The development dependencies (symfony/browser-kit,symfony/dependency-injection,symfony/form, andsymfony/validator) now support^7.2; this change is well applied and consistent.
59-59: Update Extra Symfony Version.
Theextra.symfony.requirehas been modified to^7.2, which completes the update process for this bundle.src/Sylius/Bundle/PromotionBundle/composer.json (3)
36-37: Update Core Symfony Component Constraints.
The version requirements forsymfony/clockandsymfony/framework-bundlehave been updated to include^7.2. This update directly supports the PR’s objective.
50-53: Revise Development Dependency Versions.
The changes tosymfony/browser-kit,symfony/dependency-injection,symfony/form, andsymfony/validatorto support^7.2are consistent with the overall update and properly applied.
65-65: Update Extra Symfony Requirement.
Theextra.symfony.requirevalue has been updated to^7.2, ensuring that this bundle’s configuration is aligned with the new dependency requirements.src/Sylius/Bundle/ShippingBundle/composer.json (3)
36-37: Update Symfony Package Constraints.
The updates forsymfony/clockandsymfony/framework-bundlenow correctly include^7.2in their version ranges. This properly reflects the maintenance upgrade.
48-51: Revise Development Symfony Dependencies.
The version constraints forsymfony/browser-kit,symfony/dependency-injection,symfony/form, andsymfony/validatorhave been adjusted to support^7.2. These changes are straightforward and correctly implemented.
63-64: Synchronize Extra Symfony Requirement.
Theextra.symfony.requirehas been modified to^7.2, ensuring that the configuration is uniformly updated across the package.src/Sylius/Bundle/ReviewBundle/composer.json (3)
47-47: Symfony Framework-Bundle Version Update:
The version constraint for"symfony/framework-bundle"has been updated to"^6.4.1 || ^7.2", which is in line with the PR objective. This change will enable compatibility with both Symfony 6.4.1 and 7.2 while maintaining backward compatibility within the supported range.
54-58: Updated Symfony Development Dependencies:
The require-dev dependencies for Symfony packages (i.e."symfony/browser-kit","symfony/dependency-injection","symfony/form","symfony/security-bundle", and"symfony/validator") have been updated to use the constraints"^6.4"or"^6.4.1"with the new"|| ^7.2"alternative. This ensures that development tools and tests operate with the upgraded Symfony version.
70-70: Symfony Extra Requirement Update:
The"extra"section now specifies a Symfony requirement of"^7.2", aligning globally with the dependency updates in this bundle.src/Sylius/Bundle/UiBundle/composer.json (3)
38-42: Symfony Dependency Version Updates in Require Section:
The version constraints for Symfony packages such as"symfony/config","symfony/expression-language","symfony/framework-bundle","symfony/security-core", and"symfony/security-bundle"have been updated to support"^6.4 || ^7.2". This update is consistent with the overall upgrade plan to Symfony 7.2.
53-54: Updated Symfony Development Dependencies in Require-Dev:
The development dependencies"symfony/dependency-injection"and"symfony/form"have been updated to"^6.4.1 || ^7.2". This change helps maintain consistency across both production and testing environments.
68-68: Symfony Extra Requirement in Extra Section:
The"extra"configuration now requires"^7.2", ensuring that the global Symfony version aligns perfectly with the updated package constraints throughout the bundle.src/Sylius/Bundle/CoreBundle/composer.json (4)
62-66: Symfony Dependencies Update in Require Section:
The version constraints for"symfony/clock","symfony/framework-bundle","symfony/intl","symfony/mailer", and"symfony/messenger"have been updated to use variants like"^6.4 || ^7.2"(or"^6.4.1 || ^7.2"where needed). This aligns with the project-wide objective of upgrading Symfony to version 7.2 while still supporting the 6.4 branch.
68-68: Updated Symfony Workflow Dependency:
The version for"symfony/workflow"has been revised to"^6.4 || ^7.2", ensuring that workflow-related functionalities are compatible with both supported Symfony versions.
82-83: Symfony Development Dependencies Update in Require-Dev:
The require-dev dependencies"symfony/dependency-injection"and"symfony/dotenv"have their version constraints updated to"^6.4.1 || ^7.2"and"^6.4 || ^7.2"respectively, ensuring that development and test processes leverage the updated Symfony environment.
97-97: Global Symfony Version Requirement Update:
Within the"extra"section, the Symfony requirement has been updated to"^7.2", which globally enforces the use of Symfony 7.2 across this bundle.
GSadee
left a comment
There was a problem hiding this comment.
Add a note to the UPGRADE file about bumping minimum version of SF7
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
UPGRADE-2.1.md (1)
5-6: Clarify Symfony Version Bump EntryThe update note clearly states that Symfony 7 packages have been bumped from
^7.1to^7.2. To improve the readability of the upgrade instructions, consider using sequential numbering for the list items rather than repeating the number "1." This helps reduce any potential confusion when scanning the document.-1. The minimum version of Symfony 7 packages has been bumped from Symfony `^7.1` to `^7.2` +2. The minimum version of Symfony 7 packages has been bumped from Symfony `^7.1` to `^7.2`
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
UPGRADE-2.1.md(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (14)
- GitHub Check: End-to-end tests (MySQL) / JS with Panther, PHP 8.3, Symfony ^7.2 (test_cached), MySQL 8.4, Twig ^3.3
- GitHub Check: End-to-end tests (MySQL) / Non-JS, PHP 8.3, Symfony ^7.2 (test_cached), MySQL 8.4, Twig ^3.3
- GitHub Check: End-to-end tests (MySQL) / JS with Panther, PHP 8.2, Symfony ^6.4 (test_cached), MySQL 8.0, Twig ^3.3
- GitHub Check: End-to-end tests (MySQL) / Non-JS, PHP 8.2, Symfony ^6.4 (test_cached), MySQL 8.0, Twig ^3.3
- GitHub Check: End-to-end tests (MySQL) / JS with Chromedriver, PHP 8.3, Symfony ^7.2 (test_cached), MySQL 8.4, Twig ^3.3
- GitHub Check: End-to-end tests (MySQL) / JS with Chromedriver, PHP 8.2, Symfony ^6.4 (test_cached), MySQL 8.0, Twig ^3.3
- GitHub Check: End-to-end tests (MariaDB) / Non-JS, PHP 8.3, Symfony ^7.2, MariaDB 11.4.3, State Machine Adapter winzou_state_machine
- GitHub Check: End-to-end tests (MariaDB) / Non-JS, PHP 8.3, Symfony ^7.2, MariaDB 11.4.3, State Machine Adapter symfony_workflow
- GitHub Check: End-to-end tests (MariaDB) / Non-JS, PHP 8.2, Symfony ^6.4, MariaDB 10.11.9, State Machine Adapter symfony_workflow
- GitHub Check: Packages / PHP 8.3, Symfony ^7.2
- GitHub Check: Packages / PHP 8.2, Symfony ^6.4
- GitHub Check: Frontend / NodeJS 20.x
- GitHub Check: End-to-end tests (PostgreSQL) / Non-JS, PHP 8.3, Symfony ^7.2, PostgreSQL 16.4
- GitHub Check: End-to-end tests (PostgreSQL) / Non-JS, PHP 8.2, Symfony ^6.4, PostgreSQL 15.8
🔇 Additional comments (1)
UPGRADE-2.1.md (1)
3-4: Verify Deprecation Documentation for thesylius_admin_customer_orders_statisticsRouteThe deprecation note for the
sylius_admin_customer_orders_statisticsroute is clear and concise. Please ensure that corresponding code deprecations (if any) are also documented elsewhere in the upgrade guides or release notes.
9b2e77c to
e291c8c
Compare
| Q | A |-----------------|----- | Branch? | 2.1 <!-- see the comment below --> | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no<!-- don't forget to update the UPGRADE-*.md file --> | Related tickets | #17830 | License | MIT <!-- - Bug fixes must be submitted against the 1.14 or 2.0 branch - Features and deprecations must be submitted against the 2.1 branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Streamlined the continuous integration configuration by consolidating dependency version selections, resulting in a more consistent and modern testing environment. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Summary by CodeRabbit
sylius_admin_customer_orders_statisticsroute in the upgrade notes.