Skip to content

Add Notify translation#17766

Closed
camilleislasse wants to merge 9 commits intoSylius:2.0from
camilleislasse:2.1
Closed

Add Notify translation#17766
camilleislasse wants to merge 9 commits intoSylius:2.0from
camilleislasse:2.1

Conversation

@camilleislasse
Copy link
Copy Markdown
Contributor

@camilleislasse camilleislasse commented Mar 23, 2025

Q A
Branch? 2.0
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

Add sylius.ui.notify translation
Capture d’écran 2025-03-23 à 17 02 21

Summary by CodeRabbit

  • New Features
    • Added a new localized label, "Notify," enhancing the translation and display consistency in the user interface. This update supports clearer messaging across supported languages, providing users with improved clarity when interacting with notification prompts.

@camilleislasse camilleislasse requested review from a team as code owners March 23, 2025 16:40
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 23, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

A new translation key notify was added to the messages.en.yml file in the UI bundle. This update extends the localization capabilities within the Sylius interface by ensuring the term "Notify" is available for display, supporting proper language handling in the application.

Changes

File Change Summary
src/Sylius/…/Resources/translations/messages.en.yml Added new translation key: notify with value "Notify"

Poem

Hopping through lines of code so bright,
I found a key to add some light.
“Notify” now sings across the screen,
A little change so clean and keen.
With floppy ears, I cheer the delight!


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 23, 2025

❌ Preview Environment deleted from Bunnyshell

Available commands:

  • 🚀 /bns:deploy to redeploy the environment

Prometee
Prometee previously approved these changes Mar 23, 2025
@mpysiak mpysiak changed the base branch from 2.1 to 2.0 March 24, 2025 05:38
@mpysiak mpysiak dismissed Prometee’s stale review March 24, 2025 05:38

The base branch was changed.

@mpysiak mpysiak changed the base branch from 2.0 to 2.1 March 24, 2025 05:39
mpysiak
mpysiak previously approved these changes Mar 24, 2025
GSadee and others added 8 commits March 27, 2025 07:11
This PR has been generated automatically.
For more details see
[upmerge_pr.yaml](/Sylius/Sylius/blob/1.13/.github/workflows/upmerge_pr.yaml).

**Remember!** The upmerge should always be merged with using `Merge pull
request` button.

In case of conflicts, please resolve them manually with usign the
following commands:
```
git fetch upstream
gh pr checkout <this-pr-number>
git merge upstream/2.0-docs -m "Resolve conflicts between 2.0 and 2.0-docs"
```

If you use other name for the upstream remote, please replace `upstream`
with the name of your remote pointing to the `Sylius/Sylius` repository.

Once the conflicts are resolved, please run `git merge --continue` and
push the changes to this PR.
| Q               | A
|-----------------|-----
| Branch?         | 1.14,
| Related tickets | blocks Sylius#17801 
| License         | MIT
This PR has been generated automatically.
For more details see
[upmerge_pr.yaml](/Sylius/Sylius/blob/1.13/.github/workflows/upmerge_pr.yaml).

**Remember!** The upmerge should always be merged with using `Merge pull
request` button.

In case of conflicts, please resolve them manually with usign the
following commands:
```
git fetch upstream
gh pr checkout <this-pr-number>
git merge upstream/2.0 -m "Resolve conflicts between 1.14 and 2.0"
```

If you use other name for the upstream remote, please replace `upstream`
with the name of your remote pointing to the `Sylius/Sylius` repository.

Once the conflicts are resolved, please run `git merge --continue` and
push the changes to this PR.
@GSadee GSadee added the Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). label Mar 31, 2025
@GSadee GSadee changed the base branch from 2.1 to 2.0 March 31, 2025 10:06
@GSadee GSadee dismissed mpysiak’s stale review March 31, 2025 10:06

The base branch was changed.

@GSadee
Copy link
Copy Markdown
Member

GSadee commented Mar 31, 2025

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "2.1" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

@probot-autolabeler probot-autolabeler bot added the Admin AdminBundle related issues and PRs. label Mar 31, 2025
@GSadee GSadee mentioned this pull request Mar 31, 2025
mpysiak added a commit that referenced this pull request Mar 31, 2025
| Q               | A
|-----------------|-----
| Branch?         | 2.0
| Bug fix?        | yes
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | replaces #17766 
| License         | MIT

<!--
 - Bug fixes must be submitted against the 1.14 or 2.0 branch
 - Features and deprecations must be submitted against the 2.1 branch
 - Make sure that the correct base branch is set

To be sure you are not breaking any Backward Compatibilities, check the
documentation:

https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
@GSadee
Copy link
Copy Markdown
Member

GSadee commented Mar 31, 2025

I'm closing this one, as it was replaced by #17811 and fixed in 2.0 branch with your commit, so thank you very much for your contribution 💪🏻

@GSadee GSadee closed this Mar 31, 2025
@camilleislasse
Copy link
Copy Markdown
Contributor Author

thank's !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Admin AdminBundle related issues and PRs. Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants