Missing configurationFormType to AsAttributeType by tidall87 · Pull Request #17762 · Sylius/Sylius

tidall87 · 2025-03-19T09:53:56Z

The AttributeType service has a configuration_form_type entry but the PHP AsAttributeType attribute does not.

Q	A
Branch?	1.14, 2.0, 2.1
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
License	MIT

Trying to create custom attribute type I get an error trying to use AsAttributeType because it missing the configurationFormType property as the service yaml or xml declaration.

Working

services:
    App\Attribute\AttributeType\EntityAttributeType:
        tags:
            - { name: sylius.attribute.type, attribute_type: entity, label: 'Entity', form_type: 'App\Form\Type\AttributeType\EntityAttributeType', configuration_form_type: 'App\Form\Type\AttributeType\Configuration\EntityAttributeConfigurationType' }

Error

<?php

declare(strict_types=1);

namespace App\Attribute\AttributeType;

use App\Form\Type\AttributeType\Configuration\EntityAttributeConfigurationType;
use Sylius\Bundle\AttributeBundle\Attribute\AsAttributeType;
use Sylius\Component\Attribute\AttributeType\AttributeTypeInterface;
use Sylius\Component\Attribute\Model\AttributeValueInterface;
use Symfony\Component\Validator\Context\ExecutionContextInterface;

#[AsAttributeType(
    type: 'entity',
    label: 'Entity',
    formType: \App\Form\Type\AttributeType\EntityAttributeType::class,
    configurationFormType: EntityAttributeConfigurationType::class // Unknown named parameter 'configurationFormType'
)]
final class EntityAttributeType implements AttributeTypeInterface
{
    public const string TYPE = 'entity';

    public function getStorageType(): string
    {
        return AttributeValueInterface::STORAGE_JSON;
    }

    public function getType(): string
    {
        return self::TYPE;
    }

    public function getValue(AttributeValueInterface $attributeValue)
    {
        // Implement logic to fetch values
    }

    public function validate(AttributeValueInterface $attributeValue, ExecutionContextInterface $context, array $configuration): void
    {
        // Implement validate() method.
    }
}

coderabbitai · 2025-03-19T09:54:04Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai plan to trigger planning for file edits and PR creation.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-03-19T09:55:16Z

❌ Preview Environment deleted from Bunnyshell

Available commands:

🚀 /bns:deploy to redeploy the environment

tidall87 · 2025-03-19T09:55:33Z

Hello @GSadee,

I opened this new PR because I accidentally merged 2.0 to 1.14.

tidall87 · 2025-03-19T09:57:34Z

The same PR #17745 is opened for 2.0

tidall87 · 2025-03-19T14:37:46Z

I launch CI on the 1.14 branch in my fork project and i get the same errors so the fix i added don't create error.

… PHP AsAttributeType attribute does not.

…tributeType attribute.

GSadee · 2025-03-26T13:46:28Z

We had problems with the builds, so this PR was failing, I allowed myself to rebase it to test it properly 👌🏻

GSadee · 2025-03-26T14:07:27Z

Thank you @tidall87! 🎉

tidall87 requested a review from a team as a code owner March 19, 2025 09:53

tidall87 changed the title ~~Hotfix/1.14 as attribute type missing configuration form type~~ Missing configurationFormType to AsAttributeType Mar 19, 2025

GSadee approved these changes Mar 26, 2025

View reviewed changes

tidall87 added 2 commits March 26, 2025 14:36

The AttributeType service has a configuration_form_type entry but the…

cf3986d

… PHP AsAttributeType attribute does not.

Add tests for missing configuration_form_type entry into the PHP AsAt…

3021e83

…tributeType attribute.

GSadee force-pushed the hotfix/1.14_as-attribute-type-missing-configuration-form-type branch from 1b23f9c to 3021e83 Compare March 26, 2025 13:37

GSadee added the Bug Confirmed bugs or bugfixes. label Mar 26, 2025

GSadee merged commit 211a2a6 into Sylius:1.14 Mar 26, 2025
28 checks passed

tidall87 deleted the hotfix/1.14_as-attribute-type-missing-configuration-form-type branch March 31, 2025 14:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Missing configurationFormType to AsAttributeType#17762

Missing configurationFormType to AsAttributeType#17762
GSadee merged 2 commits intoSylius:1.14from
tidall87:hotfix/1.14_as-attribute-type-missing-configuration-form-type

tidall87 commented Mar 19, 2025

Uh oh!

coderabbitai bot commented Mar 19, 2025 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

github-actions bot commented Mar 19, 2025 •

edited

Loading

Uh oh!

tidall87 commented Mar 19, 2025

Uh oh!

tidall87 commented Mar 19, 2025

Uh oh!

tidall87 commented Mar 19, 2025

Uh oh!

GSadee commented Mar 26, 2025

Uh oh!

Uh oh!

GSadee commented Mar 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

tidall87 commented Mar 19, 2025

Uh oh!

coderabbitai bot commented Mar 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

github-actions bot commented Mar 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ Preview Environment deleted from Bunnyshell

Uh oh!

tidall87 commented Mar 19, 2025

Uh oh!

tidall87 commented Mar 19, 2025

Uh oh!

tidall87 commented Mar 19, 2025

Uh oh!

GSadee commented Mar 26, 2025

Uh oh!

Uh oh!

GSadee commented Mar 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

coderabbitai bot commented Mar 19, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

github-actions bot commented Mar 19, 2025 •

edited

Loading