Missing configurationFormType to AsAttributeType by tidall87 · Pull Request #17745 · Sylius/Sylius

tidall87 · 2025-03-13T15:56:22Z

The AttributeType service has a configuration_form_type entry but the PHP AsAttributeType attribute does not.

Q	A
Branch?	2.0, 2.1
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
License	MIT

Trying to create custom attribute type I get an error trying to use AsAttributeType because it missing the configurationFormType property as the service yaml or xml declaration.

Working

services:
    App\Attribute\AttributeType\EntityAttributeType:
        tags:
            - { name: sylius.attribute.type, attribute_type: entity, label: 'Entity', form_type: 'App\Form\Type\AttributeType\EntityAttributeType', configuration_form_type: 'App\Form\Type\AttributeType\Configuration\EntityAttributeConfigurationType' }

Error

<?php

declare(strict_types=1);

namespace App\Attribute\AttributeType;

use App\Form\Type\AttributeType\Configuration\EntityAttributeConfigurationType;
use Sylius\Bundle\AttributeBundle\Attribute\AsAttributeType;
use Sylius\Component\Attribute\AttributeType\AttributeTypeInterface;
use Sylius\Component\Attribute\Model\AttributeValueInterface;
use Symfony\Component\Validator\Context\ExecutionContextInterface;

#[AsAttributeType(
    type: 'entity',
    label: 'Entity',
    formType: \App\Form\Type\AttributeType\EntityAttributeType::class,
    configurationFormType: EntityAttributeConfigurationType::class // Unknown named parameter 'configurationFormType'
)]
final class EntityAttributeType implements AttributeTypeInterface
{
    public const string TYPE = 'entity';

    public function getStorageType(): string
    {
        return AttributeValueInterface::STORAGE_JSON;
    }

    public function getType(): string
    {
        return self::TYPE;
    }

    public function getValue(AttributeValueInterface $attributeValue)
    {
        // Implement logic to fetch values
    }

    public function validate(AttributeValueInterface $attributeValue, ExecutionContextInterface $context, array $configuration): void
    {
        // Implement validate() method.
    }
}

Sylius#17667) | Q | A |-----------------|----- | Branch? | 2.1 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Related tickets | fixes Sylius#17640 | License | MIT   ## Summary by CodeRabbit - **Documentation** - Updated the upgrade guide to inform users about changes in administrative customer order statistics. - **Chores** - Deprecated an older administrative route for customer order statistics, with removal planned for a future release.

| Q | A |-----------------|----- | Branch? | 2.1 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | | License | MIT   ## Summary by CodeRabbit - **Chores** - Revised the internal merging process to prioritize our latest release branches and streamline upcoming releases.

* 2.0: (50 commits) [Docs] Fix links to new Sylius 2 documentation in README Update docs English punctuation - colon [CI] Add allow to fail for some randomly failing JS behats [Shop] Allow not setting icons for account menu items [Shop] Fix main form validation errors rendering [Admin][Taxon] Use custom attribute [UI] Fix invalid key setting on adding a collection item Skip unnecessary code block editing sylius.security.shop_regex Skip non-necessary code block [Doc] Adapt cookbook documentation about how to disable localized urls from Sylius 1 to Sylius 2 (in comments) Remove Operation after processing The partial operation definition need to be remove, else APIP will try to process it falsely. Don't remove the merged operation in case we want to debug the operations Merge instead of replacing and allow multiple api resource from various sources Remove duplicated info from the original api resource definition Change decoration priority to be just after ExtractorResourceMetadataCollectionFactory Rename service id to match class name Wrong default value fix Add AllowedTypes ...

* 2.0: [Shop] Add tom select styles [Shop] Add ux autocomplete

* 2.0: Change application's version to v1.13.12-dev Generate changelog for v1.13.11 Change application's version to v1.13.11 [Documentation] Update 1.13 version in release cycle [CS][DX] Refactor

* 2.0: Change application's version to v1.14.4-dev Generate changelog for v1.14.3 Change application's version to v1.14.3

* 2.0: Change application's version to v2.0.5-dev Generate changelog for v2.0.4 Change application's version to v2.0.4

* 2.0: Change application's version to v2.0.6-dev Generate changelog for v2.0.5 Change application's version to v2.0.5 Fix autocomplete styles [Behat] Refactor PricingElement [Behat] Enforce strict NodeElement return type [Behat][Shop] Change private keyword to protected in page classes methods [Behat][Admin] Change private keyword to protected in page classes methods [Behat][Shop] Change private keyword to protected in element classes methods [Behat][Product] Change private keyword to protected in element classes methods [Behat][Admin] Change private keyword to protected in element classes methods [Behat] Remove final keyword from element and page classes [Maintenance] Fix invalid default address component prop config [API] Fix unit test [Admin] Limit the tabler version to 1.0 [API] Fix contract tests for API Platform 4.1

* 2.0: update bunnyshell/workflows to v2

This PR has been generated automatically. For more details see [upmerge_pr.yaml](/Sylius/Sylius/blob/1.13/.github/workflows/upmerge_pr.yaml). **Remember!** The upmerge should always be merged with using `Merge pull request` button. In case of conflicts, please resolve them manually with usign the following commands: ``` git fetch upstream gh pr checkout <this-pr-number> git merge upstream/2.1 -m "Resolve conflicts between 2.0 and 2.1" ``` If you use other name for the upstream remote, please replace `upstream` with the name of your remote pointing to the `Sylius/Sylius` repository. Once the conflicts are resolved, please run `git merge --continue` and push the changes to this PR.  ## Summary by CodeRabbit - **New Features** - Enhanced product attribute validations to ensure that options like "Mug material" are accurately assigned. - Improved product listing checks for more reliable display of products in orders. - **Refactor** - Optimized dynamic collection management for smoother overall operation.

… PHP AsAttributeType attribute does not.

coderabbitai · 2025-03-13T15:56:32Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-03-13T15:57:44Z

❌ Preview Environment deleted from Bunnyshell

Available commands:

🚀 /bns:deploy to redeploy the environment

GSadee

Could you adjust the tests after this change?

GSadee

And it could be opened against 1.14 🤔

src/Sylius/Bundle/AttributeBundle/Attribute/AsAttributeType.php

…ype attribute.

…tributeType attribute.

tidall87 · 2025-03-17T18:57:29Z

@GSadee I fix and add tests and i also open a new PR from 1.14
#17755

| Q | A |-----------------|----- | Branch? | 1.13 and above | License | MIT Inspired by [Symfony](https://github.com/symfony/symfony/tree/7.3/.github/ISSUE_TEMPLATE).  ## Summary by CodeRabbit - **New Features** - Introduced updated, structured templates for submitting bug reports, documentation issues, and feature requests. - Added a configuration update that disables blank submissions and provides clear guidance with contact links for support, security, and translations. - **Chores** - Removed legacy issue templates to streamline the reporting process.

| Q | A |-----------------|----- | Branch? | 2.1 | License | MIT GitHub only recognizes `config.yml` (with `.yml` extension) for issue template configurations.

| Q | A |-----------------|----- | Branch? | 2.1 | License | MIT

| Q | A |-----------------|----- | Branch? | 2.1 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | continuation of Sylius#17759 | License | MIT

…ation-form-type

GSadee · 2025-03-26T13:47:26Z

This one can be closed as there is another PR to 1.14 and after merging it there, we will upmerge the changes to 2.0 and 2.1 👌🏻

GSadee and others added 13 commits February 11, 2025 12:21

[Admin] Deprecate unused sylius_admin_customer_orders_statistics route

4c7fb44

[CI] Update upmerge branches GH action to add 2.1

9d9544e

Merge branch '2.0' into 2.1

371707e

* 2.0: [Shop] Add tom select styles [Shop] Add ux autocomplete

Merge branch '2.0' into 2.1

a6e467b

* 2.0: Change application's version to v1.13.12-dev Generate changelog for v1.13.11 Change application's version to v1.13.11 [Documentation] Update 1.13 version in release cycle [CS][DX] Refactor

Merge branch '2.0' into 2.1

c1bbb55

* 2.0: Change application's version to v1.14.4-dev Generate changelog for v1.14.3 Change application's version to v1.14.3

Merge branch '2.0' into 2.1

a53be73

* 2.0: Change application's version to v2.0.5-dev Generate changelog for v2.0.4 Change application's version to v2.0.4

Merge branch '2.0' into 2.1

82a63ae

* 2.0: update bunnyshell/workflows to v2

The AttributeType service has a configuration_form_type entry but the…

f5b2bef

… PHP AsAttributeType attribute does not.

tidall87 requested review from a team as code owners March 13, 2025 15:56

GSadee reviewed Mar 14, 2025

View reviewed changes

GSadee added the Bug Confirmed bugs or bugfixes. label Mar 14, 2025

GSadee reviewed Mar 14, 2025

View reviewed changes

src/Sylius/Bundle/AttributeBundle/Attribute/AsAttributeType.php Outdated Show resolved Hide resolved

tidall87 added 2 commits March 17, 2025 16:10

Order missing configuration_form_type entry into the PHP AsAttributeT…

7f77b68

…ype attribute.

Add tests for missing configuration_form_type entry into the PHP AsAt…

6b439b6

…tributeType attribute.

tidall87 requested a review from GSadee March 17, 2025 16:09

Magdalena Sadowska and others added 6 commits March 18, 2025 14:38

Update Sylius Issue templates

46de6ae

Add Sylius Plus info to issue templates

8b15207

Rename config.yaml to config.yml

dd382f1

Rename config.yaml to config.yml (Sylius#17758)

3a01fdd

| Q | A |-----------------|----- | Branch? | 2.1 | License | MIT GitHub only recognizes `config.yml` (with `.yml` extension) for issue template configurations.

Update config.yml with spaces after emojis

0cf1918

GSadee and others added 4 commits March 19, 2025 10:00

Update config.yml with spaces after emojis (Sylius#17759)

519ec91

| Q | A |-----------------|----- | Branch? | 2.1 | License | MIT

Update spaces next to emojis in GH issue template

75b289c

Merge branch 'Sylius:2.1' into fix/as-attribute-type-missing-configur…

1dfbc16

…ation-form-type

probot-autolabeler bot added Admin AdminBundle related issues and PRs. Maintenance CI configurations, READMEs, releases, etc. labels Mar 19, 2025

tidall87 mentioned this pull request Mar 19, 2025

Missing configurationFormType to AsAttributeType #17762

Merged

GSadee closed this Mar 26, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Missing configurationFormType to AsAttributeType#17745

Missing configurationFormType to AsAttributeType#17745
tidall87 wants to merge 25 commits intoSylius:2.0from
tidall87:fix/as-attribute-type-missing-configuration-form-type

tidall87 commented Mar 13, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Mar 13, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

github-actions bot commented Mar 13, 2025 •

edited

Loading

Uh oh!

GSadee left a comment

Uh oh!

GSadee left a comment

Uh oh!

Uh oh!

tidall87 commented Mar 17, 2025

Uh oh!

GSadee commented Mar 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

tidall87 commented Mar 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Mar 13, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

github-actions bot commented Mar 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ Preview Environment deleted from Bunnyshell

Uh oh!

GSadee left a comment

Choose a reason for hiding this comment

Uh oh!

GSadee left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tidall87 commented Mar 17, 2025

Uh oh!

GSadee commented Mar 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

tidall87 commented Mar 13, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

github-actions bot commented Mar 13, 2025 •

edited

Loading