Skip to content

update bunnyshell/workflows to v2#17655

Merged
mpysiak merged 1 commit intoSylius:2.0from
mihaichitic:bump-bns-workflows
Feb 7, 2025
Merged

update bunnyshell/workflows to v2#17655
mpysiak merged 1 commit intoSylius:2.0from
mihaichitic:bump-bns-workflows

Conversation

@mihaichitic
Copy link
Copy Markdown
Contributor

@mihaichitic mihaichitic commented Feb 6, 2025

Q A
Branch? 2.0
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes #X, partially #Y, mentioned in #Z
License MIT

Summary by CodeRabbit

  • Chores
    • Upgraded the automation workflows managing preview environments (deploy, prepare, start, stop, delete, and cleanup) to ensure more efficient and consistent operations.
    • Enhanced environment identification by transitioning to pull request number references for smoother lifecycle management.

@mihaichitic mihaichitic requested review from a team as code owners February 6, 2025 13:48
@probot-autolabeler probot-autolabeler bot added the Maintenance CI configurations, READMEs, releases, etc. label Feb 6, 2025
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Feb 6, 2025

Walkthrough

The changes update various Bunnyshell GitHub Actions workflows. Each workflow now references version 2 of its corresponding workflow file instead of version 1. In three of the workflows, the input parameter has been renamed from env-name to pr-number, streamlining how environments are identified using the pull request or issue number. No other modifications to job configurations or control flow have been introduced.

Changes

Files Change Summary
.github/workflows/bunnyshell_cleanup-envs.yaml
.github/workflows/bunnyshell_deploy-preview-env.yaml
.github/workflows/bunnyshell_prepare-preview-env.yaml
Updated workflow file references from @v1 to @v2 without other parameter changes.
.github/workflows/bunnyshell_delete-preview-env.yaml
.github/workflows/bunnyshell_start-preview-env.yaml
.github/workflows/bunnyshell_stop-preview-env.yaml
Updated workflow file references from @v1 to @v2 and replaced the env-name parameter with pr-number.

Poem

I'm a rabbit with hops so light,
Skipping down workflows from day to night.
From v1 to v2 the changes zoom,
And "env-name" becomes "pr-number" in the room.
I celebrate each update with a joyful twitch—
CodeRabbit hops in a digital glitch!

Tip

🌐 Web search-backed reviews and chat
  • We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
  • You can disable this feature by setting web_search: false in the knowledge_base settings.
  • Please share any feedback in the Discord discussion.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4f0ab4b and a90643e.

📒 Files selected for processing (6)
  • .github/workflows/bunnyshell_cleanup-envs.yaml (1 hunks)
  • .github/workflows/bunnyshell_delete-preview-env.yaml (1 hunks)
  • .github/workflows/bunnyshell_deploy-preview-env.yaml (1 hunks)
  • .github/workflows/bunnyshell_prepare-preview-env.yaml (1 hunks)
  • .github/workflows/bunnyshell_start-preview-env.yaml (1 hunks)
  • .github/workflows/bunnyshell_stop-preview-env.yaml (1 hunks)
✅ Files skipped from review due to trivial changes (3)
  • .github/workflows/bunnyshell_deploy-preview-env.yaml
  • .github/workflows/bunnyshell_cleanup-envs.yaml
  • .github/workflows/bunnyshell_prepare-preview-env.yaml
🔇 Additional comments (6)
.github/workflows/bunnyshell_stop-preview-env.yaml (2)

11-11: Update to Workflow Version v2.
The uses field now references stop-env.yaml@v2, aligning with the migration plan. Please verify that the new version meets all required functionalities.


14-14: Rename Parameter to pr-number.
The input parameter has been updated from env-name to pr-number and now directly references ${{ github.event.issue.number }}. Confirm that the value is handled correctly in the updated workflow.

.github/workflows/bunnyshell_start-preview-env.yaml (2)

11-11: Update to Workflow Version v2.
The uses directive now points to start-env.yaml@v2, ensuring consistency with the new workflow version. Verify that this update does not introduce any unexpected behavior.


14-14: Rename Parameter to pr-number.
The parameter previously named env-name is now changed to pr-number with the expression ${{ github.event.issue.number }}. Please confirm that this meets the intended integration with the workflow logic.

.github/workflows/bunnyshell_delete-preview-env.yaml (2)

15-15: Update to Workflow Version v2.
The uses field for the delete environment job is updated to reference delete-env.yaml@v2. This change ensures all workflow versions are synchronized across the PR.


18-18: Rename Parameter to pr-number with Flexible Event Reference.
The parameter is now renamed to pr-number and uses the expression ${{ github.event.number || github.event.issue.number }}, accommodating different event types. Verify that this conditional expression consistently provides the expected number.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 6, 2025

❌ Preview Environment deleted from Bunnyshell

Available commands:

  • 🚀 /bns:deploy to redeploy the environment

@mpysiak mpysiak merged commit 3d5e539 into Sylius:2.0 Feb 7, 2025
26 checks passed
@mpysiak
Copy link
Copy Markdown
Member

mpysiak commented Feb 7, 2025

Thank you @mihaichitic! 🎉

Rafikooo added a commit that referenced this pull request Mar 3, 2025
| Q               | A
|-----------------|-----
| Branch?         | 1.14
| Bug fix?        | yes
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | #17655
| License         | MIT

<!--
 - Bug fixes must be submitted against the 1.13 branch
 - Features and deprecations must be submitted against the 1.14 branch
- Features, removing deprecations and BC breaks must be submitted
against the 2.0 branch
 - Make sure that the correct base branch is set

To be sure you are not breaking any Backward Compatibilities, check the
documentation:

https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maintenance CI configurations, READMEs, releases, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants