Fix use of locale storage service in locale switcher by JordiDekker · Pull Request #17647 · Sylius/Sylius

JordiDekker · 2025-01-30T09:42:11Z

Q	A
Branch?	2.0
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Related tickets	fixes #17646
License	MIT

Summary by CodeRabbit

Refactor
- Updated locale storage service configuration in the Sylius Shop bundle
- Modified service dependency for locale switcher

coderabbitai · 2025-01-30T09:42:19Z

Walkthrough

The pull request modifies the service configuration in the Sylius Shop Bundle's storage XML file. Specifically, it updates the service dependency for the sylius_shop.locale_switcher by changing the service argument from sylius_shop.locale_storage to sylius_shop.storage.locale. This change appears to address an issue with locale switching configuration in Sylius 2.0.

Changes

File	Change Summary
`src/Sylius/Bundle/ShopBundle/Resources/config/services/integrations/locale/storage.xml`	Updated service argument from `sylius_shop.locale_storage` to `sylius_shop.storage.locale` for `sylius_shop.locale_switcher`

Assessment against linked issues

Objective	Addressed	Explanation
Fix locale switcher service configuration [#17646]	✅
Resolve exception when disabling localised URLs	✅

Poem

🐰 A locale's dance, a service's leap,
From storage old to storage new,
Sylius hops with a configuration sweep,
Switching locales, smooth and true!
Code rabbit's magic makes it complete 🌈

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8281096 and e957281.

📒 Files selected for processing (1)

src/Sylius/Bundle/ShopBundle/Resources/config/services/integrations/locale/storage.xml (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

GitHub Check: Static checks / PHP 8.3, Symfony ^7.1
GitHub Check: Static checks / PHP 8.2, Symfony ^6.4

🔇 Additional comments (1)

src/Sylius/Bundle/ShopBundle/Resources/config/services/integrations/locale/storage.xml (1)

21-21: LGTM! The service argument is now correctly referencing the defined locale storage service.

The change fixes the service reference by using the correct service ID sylius_shop.storage.locale which is properly defined in this file and used consistently by other services.

Let's verify that no other files are still using the old service ID:

✅ Verification successful

✓ Verified: No other references to the old service ID exist in the codebase

The comprehensive search across XML, YAML, and PHP files confirms that sylius_shop.locale_storage was only used in the one location that was fixed. The change is safe to proceed with.
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:
#!/bin/bash
# Search for any remaining references to the old service ID
rg "sylius_shop.locale_storage" --type xml
Length of output: 42

Script:
#!/bin/bash
# Search for the old service ID in YAML and PHP files
echo "=== Searching YAML files ==="
rg "sylius_shop.locale_storage" --type yaml

echo -e "\n=== Searching PHP files ==="
rg "sylius_shop.locale_storage" --type php
Length of output: 224

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-01-30T10:02:04Z

Bunnyshell Preview Environment deleted

Available commands:

/bns:deploy to redeploy the environment

GSadee · 2025-01-30T14:52:22Z

Thank you @JordiDekker! 🎉

…17680) [Doc] Adapt cookbook documentation about how to disable localized urls from Sylius 1 to Sylius 2 | Q | A |-----------------|----- | Branch? | 2.0 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | issue linked #17646, merged PR #17647 | License | MIT

Fix use of locale storage service in locale switcher

e957281

JordiDekker requested review from a team as code owners January 30, 2025 09:42

probot-autolabeler bot added the Shop ShopBundle related issues and PRs. label Jan 30, 2025

GSadee approved these changes Jan 30, 2025

View reviewed changes

GSadee added the Bug Confirmed bugs or bugfixes. label Jan 30, 2025

GSadee merged commit 67e5737 into Sylius:2.0 Jan 30, 2025

tidall87 mentioned this pull request Feb 17, 2025

[Doc] Adapt how to disable localized urls from Sylius 1 to Sylius 2 #17680

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix use of locale storage service in locale switcher#17647

Fix use of locale storage service in locale switcher#17647
GSadee merged 1 commit intoSylius:2.0from
JordiDekker:JordiDekker-patch-1

JordiDekker commented Jan 30, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jan 30, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

github-actions bot commented Jan 30, 2025 •

edited

Loading

Uh oh!

GSadee commented Jan 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

JordiDekker commented Jan 30, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jan 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Assessment against linked issues

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

github-actions bot commented Jan 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bunnyshell Preview Environment deleted

Uh oh!

GSadee commented Jan 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

JordiDekker commented Jan 30, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 30, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

github-actions bot commented Jan 30, 2025 •

edited

Loading