src/Sylius/Bundle/AdminBundle/templates/order/history.html.twig (1)

3-6: LGTM! Consider extracting common prefix to a variable.

The introduction of the prefixes array aligns well with the PR objectives. However, since 'sylius_admin.common' is used across multiple templates, consider extracting it to a variable or constant to maintain DRY principles.

src/Sylius/Bundle/AdminBundle/templates/promotion_coupon/generate.html.twig (1)

3-6: LGTM! Good use of explicit parameter naming.

The changes are consistent with other templates. The explicit naming of the resource parameter (resource: promotion) improves code clarity - this is a good practice that could be adopted in other templates as well.

Also applies to: 13-13

src/Sylius/Bundle/AdminBundle/templates/shared/crud/show.html.twig (2)

3-3: Improve readability and null safety of the prefix initialization.

The current ternary operation could be clearer and safer. Consider using a more explicit if-else block or the null coalescing operator.

-{% set prefixes = configuration.vars.hook_prefix is defined ? [configuration.vars.hook_prefix] %}
+{% set prefixes = configuration.vars.hook_prefix is defined and configuration.vars.hook_prefix is not null
+    ? [configuration.vars.hook_prefix]
+    : []
+%}

---

4-7: Consider adding type hints in comments.

The template uses complex data structures. Consider adding type hints in comments to improve maintainability:

+{# @var prefixes string[] #}
 {% set prefixes = prefixes|default({})|merge([
     'sylius_admin.%resource_name%'|replace({'%resource_name%': resource_name|default(metadata.name)}),
     'sylius_admin.common'
 ]) %}

src/Sylius/Bundle/AdminBundle/templates/shared/crud/create.html.twig (1)

3-7: Consider using array literal for default value

The default({}) usage suggests an object, but an empty array [] would be more appropriate since we're working with arrays.

-{% set prefixes = prefixes|default({})|merge([
+{% set prefixes = prefixes|default([])|merge([

Additionally, consider adding documentation comments to explain the prefix structure and usage.

+{# Configures hook prefixes for CRUD templates
+   - Uses custom prefix from configuration.vars.hook_prefix if defined
+   - Adds default admin prefix with resource name
+   - Includes common admin hooks
+#}
 {% set prefixes = configuration.vars.hook_prefix is defined ? [configuration.vars.hook_prefix] %}

src/Sylius/Bundle/AdminBundle/templates/shared/crud/index.html.twig (2)

8-8: Remove extra empty line

This empty line appears to be unintentional as it's not present in other templates.

---

3-7: Well-structured implementation for configurable hook prefixes

The implementation successfully achieves the PR objectives by:

1. Maintaining backward compatibility with existing hook prefixes
2. Allowing plugins/applications to customize prefixes
3. Consistently applying the changes across all CRUD templates

The approach is clean and follows Sylius's template extension patterns.

Consider documenting this feature in:

1. The bundle's configuration reference
2. The template customization guide
3. Plugin development documentation

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro