Escape % in NonExistingGeneratorException#1565
Merged
pjedrzejewski merged 1 commit intoSylius:masterfrom Jun 21, 2014
Merged
Conversation
Contributor
|
👍, but to be honest, I would prefer to delete whole note about configuration from that exception, this is not place for such info. |
Contributor
Author
|
Lol, someone requested it in previous PR. @pjedrzejewski iirc. |
Contributor
|
IMO there should be just something like: |
Contributor
|
What's wrong with having detailed exception messages? This is way better than nothing or "check the doc", and Symfony itself pushes in that way. |
Contributor
|
👍 for the detailed exception. After all it appears only in dev environment and it useful here. |
Contributor
|
@pjedrzejewski ping, what do you think? |
pjedrzejewski
pushed a commit
that referenced
this pull request
Jun 21, 2014
Escape % in NonExistingGeneratorException
Contributor
|
The more descriptive exception, the better, I do not think this one has too much. Thanks Sasha! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.