Add additional params to display and forward route#1446
Merged
pjedrzejewski merged 1 commit intoSylius:masterfrom May 4, 2014
robinvdvleuten:additional-params
Merged
Add additional params to display and forward route#1446pjedrzejewski merged 1 commit intoSylius:masterfrom robinvdvleuten:additional-params
pjedrzejewski merged 1 commit intoSylius:masterfrom
robinvdvleuten:additional-params
Conversation
Author
|
Yeah there was a very small syntax issue which I fixed and rebased. |
Contributor
There was a problem hiding this comment.
I think using array_merge would be better here (avoid temporary variable and increase lisibility).
Author
|
@winzou I have fixed them. An array_merge was indeed better. |
pjedrzejewski
pushed a commit
that referenced
this pull request
May 4, 2014
Add additional params to display and forward route
Contributor
|
Thanks Robin! That is a nice addition. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First a lot of thanks for making such an awesome bundle who saved me a lot of work creating multistep forms!
The only thing though was that I had overridden the default display route with a route that contained additional parameters. I have added some code where you can add those parameters with the ProcessBuilder. You can see in the Coordinator class how these params are used.
Cheers,
Robin