Skip to content

Fix some composer.json files#1422

Merged
pjedrzejewski merged 1 commit intoSylius:masterfrom
stloyd:bugfix/composer_files
Jun 21, 2014
Merged

Fix some composer.json files#1422
pjedrzejewski merged 1 commit intoSylius:masterfrom
stloyd:bugfix/composer_files

Conversation

@stloyd
Copy link
Copy Markdown
Contributor

@stloyd stloyd commented Apr 23, 2014

Without this trying to test Pricing Component is broken.

@stloyd
Copy link
Copy Markdown
Contributor Author

stloyd commented Apr 23, 2014

@pjedrzejewski @jjanvier @umpirsky Anything blocking this one?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure about this? The namespace starts with spec.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both ways are correct, but this one makes it consistent with other composer.json files.

- add missing dependencies
- remove not required ones
- adjust some dependencies to be same like in other parts of Sylius
- add missing dev stability parameter when required
@stloyd
Copy link
Copy Markdown
Contributor Author

stloyd commented Jun 18, 2014

@pjedrzejewski We really need to have Travis setups for all read-only tree splits, without this we can't be sure that bundles/components have all required dependencies (i.e. Core component have 2 missing ones)...

Additionally I have added "minimum-stability": "dev" which is required when you need to install dev package that depends on dev package (think PricingBundle -> ResourceBundle -> DoctrineBundle), same way it's done by Symfony same way to allow the Components/Bundle being testable (go to folder of i.e. PricingBundle and call composer install).

@stloyd
Copy link
Copy Markdown
Contributor Author

stloyd commented Jun 21, 2014

@pjedrzejewski This should be merged before relase of 0.10 IMO.

pjedrzejewski pushed a commit that referenced this pull request Jun 21, 2014
@pjedrzejewski pjedrzejewski merged commit a46c964 into Sylius:master Jun 21, 2014
@pjedrzejewski
Copy link
Copy Markdown
Contributor

Looks good to me, I renabled travis for all repos, let's see what happens. :)

@stloyd stloyd deleted the bugfix/composer_files branch June 21, 2014 13:06
pamil pushed a commit to pamil/Sylius that referenced this pull request May 7, 2019
pamil pushed a commit to pamil/Sylius that referenced this pull request May 7, 2019
pamil pushed a commit to pamil/Sylius that referenced this pull request May 7, 2019
pamil pushed a commit to pamil/Sylius that referenced this pull request May 7, 2019
pamil pushed a commit to pamil/Sylius that referenced this pull request May 7, 2019
pamil pushed a commit to pamil/Sylius that referenced this pull request May 7, 2019
pamil pushed a commit to pamil/Sylius that referenced this pull request May 7, 2019
pamil pushed a commit to pamil/Sylius that referenced this pull request May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants