Skip to content

PHP 7.4 syntax in Sylius bundles vol.1#13038

Merged
GSadee merged 1 commit intoSylius:1.10from
Zales0123:php7.4-syntax-bundles
Sep 6, 2021
Merged

PHP 7.4 syntax in Sylius bundles vol.1#13038
GSadee merged 1 commit intoSylius:1.10from
Zales0123:php7.4-syntax-bundles

Conversation

@Zales0123
Copy link
Copy Markdown
Contributor

Q A
Branch? 1.10
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets related to #12891
License MIT

All bundles except CoreBundle and ApiBundle which I left for dessert (and by dessert I mean separate PRs - they're just too big 🚀)

@Zales0123 Zales0123 added Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). DX Issues and PRs aimed at improving Developer eXperience. labels Aug 31, 2021
@Zales0123 Zales0123 requested a review from a team as a code owner August 31, 2021 15:23
@probot-autolabeler probot-autolabeler bot added the Admin AdminBundle related issues and PRs. label Aug 31, 2021
@Zales0123 Zales0123 mentioned this pull request Aug 31, 2021
10 tasks
@Zales0123 Zales0123 force-pushed the php7.4-syntax-bundles branch from 9aac5ac to fed2953 Compare August 31, 2021 15:35
Copy link
Copy Markdown
Member

@GSadee GSadee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But the rebase is needed

@Zales0123 Zales0123 force-pushed the php7.4-syntax-bundles branch from fed2953 to de8a9c8 Compare September 3, 2021 13:36
@Zales0123
Copy link
Copy Markdown
Contributor Author

@GSadee done 🖖

@GSadee GSadee merged commit 592336e into Sylius:1.10 Sep 6, 2021
@GSadee
Copy link
Copy Markdown
Member

GSadee commented Sep 6, 2021

Thank you, Mateusz! 🥇

@Zales0123 Zales0123 deleted the php7.4-syntax-bundles branch September 16, 2021 07:29
GSadee added a commit that referenced this pull request Sep 17, 2021
This PR was merged into the 1.10 branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         | 1.10
| Bug fix?        | no
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | based on #13038, related to #12891
| License         | MIT

`CoreBundle` + PHP 7.4  = 🎉 

Commits
-------

54106f7 PHP 7.4 syntax in bundles vol.2
fb4158e Fix coding standards
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Admin AdminBundle related issues and PRs. DX Issues and PRs aimed at improving Developer eXperience. Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants