Fix bad taxation label when decimal value#1300
Merged
pjedrzejewski merged 4 commits intoSylius:masterfrom May 4, 2014
lenybernard:patch-1
Merged
Fix bad taxation label when decimal value#1300pjedrzejewski merged 4 commits intoSylius:masterfrom lenybernard:patch-1
pjedrzejewski merged 4 commits intoSylius:masterfrom
lenybernard:patch-1
Conversation
Contributor
|
This change breaks tests, mainly because with this change all |
Contributor
|
@lenybernard Could you update Behat scenarios, please? Thanks! |
Contributor
|
Hmm, don't like to see 20.00% when not needed. @lenybernard maybe can you update to only show decimals, if there are decimals needed? |
Contributor
Author
|
Sure I'll fix the behat tests and display only taxes when needed. |
Contributor
Author
|
done. |
Contributor
|
Can you squash your commits? Thanks! |
Contributor
|
@lenybernard PR needs rebase and squash, thanks! |
Contributor
Author
|
Yes I will but I don't have so much time, Nevertheless I'll try to do it this week. |
pjedrzejewski
pushed a commit
that referenced
this pull request
May 4, 2014
Fix bad taxation label when decimal value
Contributor
|
Thanks Leny! 👍 |
Contributor
Author
|
Wecome, sorry for rebase and squash, I had no time to do that 😴 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For example if you have a tax of 5.5%, the adjustment description was :
but it was expected :