Thanks for the patch @fullpipe, what do you think @winzou?

Experiencing same issue. Inventory unit doesn't go away even I decrease the item quantity in cart. This result in inventory unit and order content doesn't match.

@kayue Did you try this patch? I think we should consider adding some scenarios, which ensure that Administrator sees correct amount of inventory units in backend. As well as states, this would cover our inventory, which seems to be a bit buggy now. :/

Will try all this today, that's crazy how I missed it...

@pjedrzejewski This fix works for me :)

Thanks @fullpipe

It's all good but we miss inventory units deletion when clearing cart.
Can't see why, as we have a cascade all on the relation OrderItem > InventoryUnits and on Order > OrderItem. In the case of order item deletion only (remove 1 item from the cart), inventory units are well deleted though.
@fullpipe @kayue idea?

@winzou Sorry I can't follow you. When do we "clearing cart"? How to reproduce this?

When user press "clear cart". It deletes anyway the cart so there shouldn't be any confusion on the admin side, but this is still an issue.

@winzou Let's tackle this in separate PR, as this current issue is much more annoying. Thank you @fullpipe & @kayue for testing. :)

I think I found the problem.
"clear cart" does not clear inventory units because Order is softdeletable
And $this->cartManager->remove($event->getCart()); does not trigger cascade-remove

Arf correct this is stupid...
@pjedrzejewski we really need a service that handles cart operations (create, delete, add item, remove item, etc.). No operation on cart are allowed outside of this service. So that we ensure that every events are trigger in every case, with the right parameter and information on which item is added, etc. I'll try to manage this.