[TwigHooks] Remove translations on profiler#160
Merged
loic425 merged 1 commit intoSylius:mainfrom Dec 12, 2024
Merged
Conversation
Prometee
approved these changes
Dec 12, 2024
NoResponseMate
added a commit
to Sylius/Sylius
that referenced
this pull request
Dec 13, 2024
| Q | A |-----------------|----- | Branch? |2.0 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | | License | MIT <!-- - Bug fixes must be submitted against the 1.13 branch - Features and deprecations must be submitted against the 1.14 branch - Features, removing deprecations and BC breaks must be submitted against the 2.0 branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> The interesting thing on Sylius commerce side is that it will fix the profiler translations on the Twig hooks part. Sylius/Stack#160
GSadee
pushed a commit
to Sylius/SyliusAdminBundle
that referenced
this pull request
Jan 13, 2025
| Q | A |-----------------|----- | Branch? |2.0 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | | License | MIT <!-- - Bug fixes must be submitted against the 1.13 branch - Features and deprecations must be submitted against the 1.14 branch - Features, removing deprecations and BC breaks must be submitted against the 2.0 branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> The interesting thing on Sylius commerce side is that it will fix the profiler translations on the Twig hooks part. Sylius/Stack#160
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Symfony packages, they do not use translations for profiling pages.
Technical words like those ones are hard to maintain and currently, we have keys instead of translations on fr, it, de...
Before
