This repository was archived by the owner on Jun 1, 2023. It is now read-only.
Improve file enumeration in generate subcommand #229
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a few small changes to improve the ergonomics and performance of the
generatesubcommand:First, we pass
.isDirectoryKeyinto theincludingPropertiesForKeysargument when constructing a file enumerator. I haven't profiled this, but it should be faster for the file manager to pick this up during enumeration rather than fetching it in the loop on-demand.Second, we pass
.skipsHiddenFilesand.skipsPackageDescendantsas enumeration options. Among other things, this prevents cloned dependencies in.swiftpmfrom being pulled in when passing the current directory (.) as an input argument.Third, we tell the file enumerator to skip the top-level
Tests/directory. In the future, we may replace this with code that parses thePackage.swiftmanifest file and identifies the source files directly.