Skip to content

[Bugfix:Submission] Fix non-VCS repo error#12608

Open
RishikaBothra wants to merge 10 commits intoSubmitty:mainfrom
RishikaBothra:fix/team-page-vcs-repo-message
Open

[Bugfix:Submission] Fix non-VCS repo error#12608
RishikaBothra wants to merge 10 commits intoSubmitty:mainfrom
RishikaBothra:fix/team-page-vcs-repo-message

Conversation

@RishikaBothra
Copy link
Copy Markdown

@RishikaBothra RishikaBothra commented Mar 19, 2026 •
edited
Loading

Why is this Change Important & Necessary?

Closes #12579

This change is important because, in team gradeables even when the assignment doesn't say to submit it as Git/VCS repo it states the error message ->Your repo doesn't exist contact your instructor... .This message should only appear for VCS assignments. Not for Non-VCS(file) assignment

What is the New Behavior?

Before => There was error in team gradeables that repo doesn't exist even if the assignment was Non-VCS
image

After=> Now it first checks if the assignment is of GIT/VCS if yes then only shows that error if not then it does not shows that error.
image

What steps should a reviewer take to reproduce or test the bug or new feature?

  1. Login as student
  2. Go in any courses (for eg.sample)
  3. In the section of gradeables you will see a gradeables with blue box named MANAGE TEAM (for eg.Open Team Homework)
image 4. Click the MANAGE TEAM button image 5. Before fix: "Your repository does not exist" error incorrectly appears 6. After fix: No repository message appears

Automated Testing & Documentation

A Cypress test at:
site/cypress/e2e/Cypress-Gradeable/team_repository_message.spec.js

  • Non-VCS team gradeables: repo message should NOT appear
  • VCS team gradeables without repo: error message should appear
  • VCS team gradeables with repo: git clone instructions should appear

Other information

  • No breaking
  • No migrations
  • No security concerns

@github-project-automation github-project-automation bot moved this to Seeking Reviewer in Submitty Development Mar 19, 2026
@RishikaBothra RishikaBothra mentioned this pull request Mar 19, 2026
Open
@IDzyre
Copy link
Copy Markdown
Member

IDzyre commented Mar 24, 2026 •
edited
Loading

Hey @RishikaBothra, thank you for your contribution!

Please update your PR title to use our required format
[<TYPE>:<MODULE>] <SUBJECT>, where <SUBJECT> is 40 chars max.
See also: https://submitty.org/developer/getting_started/make_a_pull_request

Please also use our PR description template:
https://raw.githubusercontent.com/Submitty/Submitty/refs/heads/main/.github/PULL_REQUEST_TEMPLATE.md

Also, ensure tests are passing in CI.

Once this pull request adheres to all Submitty conventions, we will proceed with a full review.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 24, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 21.65%. Comparing base (20baa2c) to head (29751af).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main   #12608   +/-   ##
=========================================
  Coverage     21.65%   21.65%           
  Complexity     9654     9654           
=========================================
  Files           268      268           
  Lines         36240    36240           
  Branches        487      487           
=========================================
  Hits           7846     7846           
  Misses        27911    27911           
  Partials        483      483
Flag Coverage Δ
autograder 21.32% <ø> (ø)
js 2.04% <ø> (ø)
migrator 100.00% <ø> (ø)
php 20.67% <ø> (ø)
python_submitty_utils 80.08% <ø> (ø)
submitty_daemon_jobs 91.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RishikaBothra RishikaBothra changed the title [Bugfix] : Remove the error coming in team gradeables of repo does not exist even when it is file submission(Non-VCS) [Bugfix:team-gradeables] Fix non-VCS repo error Mar 25, 2026
@RishikaBothra
Copy link
Copy Markdown
Author

RishikaBothra commented Mar 25, 2026

Hey @RishikaBothra, thank you for your contribution!

Please update your PR title to use our required format [<TYPE>:<MODULE>] <SUBJECT>, where <SUBJECT> is 40 chars max. See also: https://submitty.org/developer/getting_started/make_a_pull_request

Please also use our PR description template: https://raw.githubusercontent.com/Submitty/Submitty/refs/heads/main/.github/PULL_REQUEST_TEMPLATE.md

Also, ensure tests are passing in CI.

Once this pull request adheres to all Submitty conventions, we will proceed with a full review.

Hi @IDzyre . I did the change in the name of the PR as u suggest and also corrected the CI test case error.

@RishikaBothra RishikaBothra changed the title [Bugfix:team-gradeables] Fix non-VCS repo error [Bugfix:team-Submission] Fix non-VCS repo error Mar 25, 2026
@RishikaBothra RishikaBothra changed the title [Bugfix:team-Submission] Fix non-VCS repo error [Bugfix:Submission] Fix non-VCS repo error Mar 25, 2026
@RishikaBothra
Copy link
Copy Markdown
Author

RishikaBothra commented Mar 25, 2026

Hi @IDzyre . Fixed the new issues which came in CI test

IDzyre
IDzyre reviewed Mar 27, 2026
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IDzyre IDzyre IDzyre left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

Submitty Development
Status: Seeking Reviewer

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

repository error message on manage team page

2 participants

@RishikaBothra @IDzyre