[Bugfix:System] vagrant workers up setup fix#12465
Merged
Conversation
…ty user exists, instead of just checking it's other versions.
2 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12465 +/- ##
============================================
+ Coverage 21.67% 21.70% +0.03%
- Complexity 9620 9626 +6
============================================
Files 268 268
Lines 36164 36188 +24
Branches 486 486
============================================
+ Hits 7837 7856 +19
- Misses 27845 27850 +5
Partials 482 482
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Farhanxikram
approved these changes
Feb 24, 2026
Farhanxikram
left a comment
There was a problem hiding this comment.
Functionality review:
I ran vagrant workers up on the main branch and it erroed and failed to make the worker correctly,
I then ran vagrant workers up on this branch and everything worked perfectl,y :)
GarvitKhandelwal31
pushed a commit
to GarvitKhandelwal31/Submitty
that referenced
this pull request
Mar 5, 2026
### Why is this Change Important & Necessary? Fixes Submitty#12409 when creating a worker machine from vagrant (`vagrant workers up`), it fails in multiple steps during the setup process. First, it gets tripped on a NodeJS gpg keygen failure, then a MOTD permissions issue, and then the submitty user doesn't actually get created because of a malformed if statement in a setup worker bash script. ### What is the New Behavior? The worker machine will now successfully generate without errors. ### What steps should a reviewer take to reproduce or test the bug or new feature? on main, run vagrant workers generate, then vagrant workers up, and observe the failure. Do the same thing in my branch and observe that it properly generates. ### Automated Testing & Documentation ### Other information There should be no critically breaking changes on any production machines, given that running vagrant workers is not a production variant of running workers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this Change Important & Necessary?
Fixes #12409
when creating a worker machine from vagrant (
vagrant workers up), it fails in multiple steps during the setup process. First, it gets tripped on a NodeJS gpg keygen failure, then a MOTD permissions issue, and then the submitty user doesn't actually get created because of a malformed if statement in a setup worker bash script.What is the New Behavior?
The worker machine will now successfully generate without errors.
What steps should a reviewer take to reproduce or test the bug or new feature?
on main, run vagrant workers generate, then vagrant workers up, and observe the failure. Do the same thing in my branch and observe that it properly generates.
Automated Testing & Documentation
Other information
There should be no critically breaking changes on any production machines, given that running vagrant workers is not a production variant of running workers.