[Bugfix:Forum] Enable discussion forum by default#12414
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12414 +/- ##
============================================
- Coverage 21.73% 21.72% -0.02%
+ Complexity 9623 9619 -4
============================================
Files 268 268
Lines 36167 36161 -6
Branches 486 486
============================================
- Hits 7862 7856 -6
Misses 27823 27823
Partials 482 482
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
roye2
left a comment
There was a problem hiding this comment.
I tested both the original functionality and the new functionality of the discussion forum being enabled by default. Everything seems to work as intended. I appreciated the extensive comments in migration/migrator/migrations/course/20260202162817_initialize_discussion_categories.py as someone that is new to Python. My only suggestion is to update the PR to include the link (https://submitty.org/sysadmin/configuration/course_creation) to the course creation guide, as I personally didn't know that the course creation button on the Submitty VM doesn't work.
Rkoester47
left a comment
There was a problem hiding this comment.
I was able to test the functionality of this PR and can confirm that discussion forum is enabled by default when creating a course while on this branch. On other branches, I was able to observe that the discussion forum is not enabled by default, as described by the PR. The implementation of this change looks reasonable, and the functionality of the forum itself remains intact while using a course created on this branch. Creating a post, deleting a post and replying to a post still all work as originally intended.
Why is this Change Important & Necessary?
Fixes #12335
What is the New Behavior?
Previously, the discussion forum would not be created by default when a course is made. Now, the discussion forum is created by default.
What steps should a reviewer take to reproduce or test the bug or new feature?
Test old behavior:
Test new behavior:
Automated Testing & Documentation
This feature is not yet tested.
Other information
Since this PR removes the automatic creation of the default categories when the enable forum checkbox is toggled, a migration has been added that inserts the 4 default forum categories into existing classes, if none are present.