Skip to content

[SYSADMIN ACTION][Dependency] Bump PHP to 8.2#12363

Merged
bmcutler merged 6 commits intomainfrom
php_bump_8.2
Feb 27, 2026
Merged

[SYSADMIN ACTION][Dependency] Bump PHP to 8.2#12363
bmcutler merged 6 commits intomainfrom
php_bump_8.2

Conversation

@cjreed121
Copy link
Member

@cjreed121 cjreed121 commented Feb 1, 2026 •
edited
Loading

Why is this Change Important & Necessary?

PHP 8.1 is EOL and we should update to 8.2 which is not EOL.

What is the New Behavior?

PHP 8.2 is used now.

What steps should a reviewer take to reproduce or test the bug or new feature?

  • Verify migration works correctly locally
  • Verify all pages perform as expected

Automated Testing & Documentation

Docs PR: Submitty/submitty.github.io#723

@github-project-automation github-project-automation bot moved this to Seeking Reviewer in Submitty Development Feb 1, 2026
@automateprojectmangement automateprojectmangement bot moved this from Seeking Reviewer to Work in Progress in Submitty Development Feb 1, 2026
@cjreed121 cjreed121 changed the title [Dependency:System] Bump PHP to 8.2 [Dependency] Bump PHP to 8.2 Feb 1, 2026
@codecov
Copy link

codecov bot commented Feb 1, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 21.65%. Comparing base (44f0eaf) to head (6cd5308).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #12363      +/-   ##
============================================
- Coverage     21.68%   21.65%   -0.03%     
  Complexity     9638     9638              
============================================
  Files           268      268              
  Lines         36233    36233              
  Branches        486      486              
============================================
- Hits           7856     7847       -9     
- Misses        27895    27904       +9     
  Partials        482      482
Flag Coverage Δ
autograder 21.39% <ø> (ø)
js 2.04% <ø> (ø)
migrator 100.00% <ø> (ø)
php 20.68% <0.00%> (-0.03%) ⬇️
python_submitty_utils 80.08% <ø> (ø)
submitty_daemon_jobs 90.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cjreed121
Copy link
Member Author

cjreed121 commented Feb 1, 2026

This should probably get a sysadmin action tag

@cjreed121 cjreed121 changed the title [Dependency] Bump PHP to 8.2 [SYSADMIN ACTION][Dependency] Bump PHP to 8.2 Feb 1, 2026
@cjreed121 cjreed121 marked this pull request as ready for review February 1, 2026 18:49
@automateprojectmangement automateprojectmangement bot moved this from Work in Progress to Seeking Reviewer in Submitty Development Feb 1, 2026
williamjallen
williamjallen reviewed Feb 3, 2026
View reviewed changes
Copy link
Member

@williamjallen williamjallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment about migration design practices, but looks good overall.

@Farhanxikram
Copy link

Farhanxikram commented Feb 6, 2026 •
edited
Loading

Functionality review:
I went through all of the tabs on Submitty and the UI as well as functionality of each page seemed to hold up perfectly fine. I also tried out putting in a couple files in the submission page, looking at the TA side of grading assignments, doing grade overrides, and creating a new course and everything went seamlessly.

One thing worth mention is I was having issues when branching into this PR. The first time I submitty_install after it was done my localhost was stuck on the "submitty's been updated wait 2 minutes" page. To fix this I left the branch, ran submitty install to go back to php's old version, and then branched back into this Pr and then ran submitty_install again and it worked just fine. This could have just been me making mistakes while downloading things though.

OS: windows 11
web browser: Chrome

williamjallen
williamjallen reviewed Feb 10, 2026
View reviewed changes
Copy link
Member

@williamjallen williamjallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, once the lockfile conflict is addressed.

Farhanxikram
Farhanxikram approved these changes Feb 13, 2026
View reviewed changes
Copy link

@Farhanxikram Farhanxikram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment

@github-project-automation github-project-automation bot moved this from Seeking Reviewer to Awaiting Maintainer Review in Submitty Development Feb 13, 2026
@bmcutler
Copy link
Member

bmcutler commented Feb 26, 2026 •
edited
Loading

@cjreed121
Can you fix the merge conflict with site/composer.lock please?

@bmcutler bmcutler merged commit cdd2676 into main Feb 27, 2026
25 checks passed
@bmcutler bmcutler deleted the php_bump_8.2 branch February 27, 2026 05:22
@github-project-automation github-project-automation bot moved this from Awaiting Maintainer Review to Done in Submitty Development Feb 27, 2026
GarvitKhandelwal31 pushed a commit to GarvitKhandelwal31/Submitty that referenced this pull request Mar 5, 2026
@cjreed121 @GarvitKhandelwal31
[SYSADMIN ACTION][Dependency] Bump PHP to 8.2 (Submitty#12363)
cbfd2fe 
### Why is this Change Important & Necessary?
PHP 8.1 is EOL and we should update to 8.2 which is not EOL.

### What is the New Behavior?
PHP 8.2 is used now.

### What steps should a reviewer take to reproduce or test the bug or
new feature?
* Verify migration works correctly locally
* Verify all pages perform as expected

### Automated Testing & Documentation
Docs PR: Submitty/submitty.github.io#723
@IDzyre IDzyre mentioned this pull request Mar 24, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@williamjallen williamjallen williamjallen left review comments

@Farhanxikram Farhanxikram Farhanxikram approved these changes

Assignees

No one assigned

Labels

None yet

Projects

Submitty Development
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cjreed121 @Farhanxikram @bmcutler @williamjallen