[Feature:InstructorUI] Update Course ID from Manage Sections by Rkoester47 · Pull Request #12354 · Submitty/Submitty

Rkoester47 · 2026-01-27T18:29:37Z

Why is this Change Important & Necessary?

Fixes #8770
Currently, there is no way to update the Course ID for a given section on the Manage Sections page.

What is the New Behavior?

Now, there are pencil buttons next to the Course ID for each section. These buttons will open a popup so that an instructor can change the Course ID from this page. This change will update the Course ID in both the Submitty Database and Course Database.

The styling for the pencil buttons was taken directly from the User Profile page pencil buttons.

What steps should a reviewer take to reproduce or test the bug or new feature?

Login as Instructor
Go to Sample > Manage Sections
Click the pencil button next to a course section
Update the Course ID with a new number and save - ensure the success banner displays.
Attempt to update a section to have the same Course ID as another section - error banner should display.

Automated Testing & Documentation

Other information

This is not a breaking change.

Started functionality for the Update Course ID UI added previously, based on delete section and add section.

Switching the UI approach for updating course ID.

Began implementing backend part of changing course ID.

codecov · 2026-01-27T18:30:47Z

Codecov Report

❌ Patch coverage is 0% with 27 lines in your changes missing coverage. Please review.
✅ Project coverage is 21.65%. Comparing base (9c7283a) to head (b0b0ed1).
⚠️ Report is 23 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #12354      +/-   ##
============================================
- Coverage     21.67%   21.65%   -0.02%     
- Complexity     9623     9630       +7     
============================================
  Files           268      268              
  Lines         36171    36198      +27     
  Branches        486      486              
============================================
  Hits           7840     7840              
- Misses        27849    27876      +27     
  Partials        482      482

Flag	Coverage Δ
autograder	`21.39% <ø> (ø)`
js	`2.04% <ø> (ø)`
migrator	`100.00% <ø> (ø)`
php	`20.68% <0.00%> (-0.02%)`	⬇️
python_submitty_utils	`80.08% <ø> (ø)`
submitty_daemon_jobs	`90.72% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This reverts commit c12fdbe.

This reverts commit 00c62b5.

aconfo

I primarily conducted a functionality test. When testing the changed work, immediately I noticed that the "pencil" icons to change the course ID were present. Clicking on it opened up a small window that allows course ID to be changed, at which point I conducted a variety of tests for edge cases. It successfully limited me to inputting only a 5 digit number, with no letters working which is all good. It also prevented me from inputting an empty ID. There was however, one problem I noticed when testing. If, let's say, I make a course ID 00002. Now when I try to add a new course ID to another course it would deny me from adding 00002 as its ID, which is good and intended. The problem arose after I removed 00002 as an ID from the course I assigned it to, where after removing it, I still couldn't add it as a valid ID as seen below:

It is also may be important to note that this prevented me from adding 00002 to any of the listed sections after 00002 was removed. This could pose a significant problem and prevent course ID's from being edited, and I would recommend this be changed to only restrict course ID's being used.

JManion32

I did a code review. I left some comments throughout the code. Great job with this so far!

site/app/controllers/admin/UsersController.php

site/public/css/rotatingsectionsform.css

site/app/templates/admin/users/RotatingSectionsForm.twig

site/app/libraries/database/DatabaseQueries.php

-Moved user-profile.css and rotating-sections.css to server.css -updated "semester" to "term" -removed csrf check -updated query logic

dagemcn · 2026-02-06T17:48:32Z

I did a functionality review on this, the previous issue that @aconfo mentioned seems to be resolved, though I can't speak to the changes requested for the code. This is a great quality of life improvement for instructors. I tested quite a few special characters along with alt-code characters. Everything is appears to be working as intended. One thing I noticed is a redundant close button, although I'm not sure if that is the correct style for a pop up menu like this.

Someone more knowledgeable may be able to comment on this.

dagemcn

Refer to my above comment, I was confused on the workflow, my apologies.

JManion32 · 2026-02-06T17:57:32Z

I did a functionality review on this, the previous issue that @aconfo mentioned seems to be resolved, though I can't speak to the changes requested for the code. This is a great quality of life improvement for instructors. I tested quite a few special characters along with alt-code characters. Everything is appears to be working as intended. One thing I noticed is a redundant close button, although I'm not sure if that is the correct style for a pop up menu like this. Someone more knowledgeable may be able to comment on this.

@dagemcn We use a template for popups so we don't have to build a new one from scratch every time we need one. The close button in the top right is always there, and I believe the one on the bottom can be customized, but usually just stays as the default.

Rkoester47 · 2026-02-10T22:42:23Z

I did a code review. I left some comments throughout the code. Great job with this so far!

Thank you for the feedback. I implemented the requested changes, and also please take a look at my reply to you on PR#12412, about merging my two PRs before moving the Javascript to its own .js file. I propose moving the add section input to a better spot in #12429 , and then a refactor PR for the page in the future.

JManion32

Great work with this pull request, all of your changes look good to me. Just remove the comment I tagged about moving from another file.

site/public/css/server.css

Rkoester47 added 6 commits January 23, 2026 12:56

Updated the Manage Sections UI

752b19e

Beginning of Functionality

406478e

Started functionality for the Update Course ID UI added previously, based on delete section and add section.

Changing from text box to pencil button

d9e00e0

Switching the UI approach for updating course ID.

Added pencil buttons and styling

fbeb2f8

Added DB queries and updateCourseID

8ab7182

Began implementing backend part of changing course ID.

Added newline to end of file

e7f0528

github-project-automation bot added this to Submitty Development Jan 27, 2026

github-project-automation bot moved this to Seeking Reviewer in Submitty Development Jan 27, 2026

automateprojectmangement bot moved this from Seeking Reviewer to Work in Progress in Submitty Development Jan 27, 2026

Rkoester47 added 18 commits January 27, 2026 17:41

Created Popup form for course ID

b56417f

Updated Popup form and logic

38f0935

Can update the Course ID from popup

18619d1

Pop up successfully updates Course ID

abb6092

Unique Course ID Safeguard

d36cb1c

PHP and CSS Lint fixes

376a03f

Additional lint fixes

c12fdbe

Revert "Additional lint fixes"

3a5f871

This reverts commit c12fdbe.

Added return type and argument types

00c62b5

Revert "Added return type and argument types"

54499b9

This reverts commit 00c62b5.

Updated parameter type and unique id safeguard logic for Php lint errors

92ef562

Added return types and updated Json Response

746aaa4

php lint fixes

82c3d50

Reformatted query for php lint compliance

049c7b5

Additional Php Lint fixes

3e85a23

Removed whitespace at end of lines

f10cb35

Updated courseIdExists to not use query() return value

073bfd3

Merge branch 'main' into set-courseid-manage-sections

7ce15a2

Rkoester47 marked this pull request as ready for review February 3, 2026 17:41

automateprojectmangement bot moved this from Work in Progress to Seeking Reviewer in Submitty Development Feb 3, 2026

aconfo requested changes Feb 3, 2026

View reviewed changes

github-project-automation bot moved this from Seeking Reviewer to Work in Progress in Submitty Development Feb 3, 2026

Resolved updating recently changed ID issue

7303fd7

Rkoester47 requested a review from aconfo February 5, 2026 01:55

automateprojectmangement bot moved this from Work in Progress to In Review in Submitty Development Feb 5, 2026

JManion32 requested changes Feb 6, 2026

View reviewed changes

github-project-automation bot moved this from In Review to Work in Progress in Submitty Development Feb 6, 2026

JManion32 mentioned this pull request Feb 6, 2026

[Feature:InstructorUI] Delete Sections with Button #12412

Merged

Implemented Feedback

107520f

-Moved user-profile.css and rotating-sections.css to server.css -updated "semester" to "term" -removed csrf check -updated query logic

dagemcn self-requested a review February 6, 2026 17:49

automateprojectmangement bot moved this from Work in Progress to In Review in Submitty Development Feb 6, 2026

dagemcn removed their request for review February 6, 2026 17:50

dagemcn reviewed Feb 6, 2026

View reviewed changes

Rkoester47 added 4 commits February 6, 2026 13:07

Added newline to end of file

ebb989b

Merge branch 'main' into set-courseid-manage-sections

dd745bc

Fixed formatting error caused by merge conflict

290a728

CSS fix

f73ec8f

Rkoester47 requested review from JManion32 and dagemcn February 10, 2026 22:42

Rkoester47 mentioned this pull request Feb 13, 2026

Move "Add Section" text area on Manage Sections #12429

Closed

JManion32 approved these changes Feb 14, 2026

View reviewed changes

site/public/css/server.css Outdated Show resolved Hide resolved

Removed comment

b0b0ed1

Rkoester47 moved this from In Review to Ready to Merge in Submitty Development Feb 20, 2026

bmcutler merged commit ec592ba into main Feb 20, 2026
25 checks passed

bmcutler deleted the set-courseid-manage-sections branch February 20, 2026 18:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Feature:InstructorUI] Update Course ID from Manage Sections#12354

[Feature:InstructorUI] Update Course ID from Manage Sections#12354
bmcutler merged 31 commits intomainfrom
set-courseid-manage-sections

Rkoester47 commented Jan 27, 2026 •

edited

Loading

Uh oh!

codecov bot commented Jan 27, 2026 •

edited

Loading

Uh oh!

aconfo left a comment •

edited

Loading

Uh oh!

JManion32 left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dagemcn commented Feb 6, 2026

Uh oh!

dagemcn left a comment

Uh oh!

JManion32 commented Feb 6, 2026

Uh oh!

Rkoester47 commented Feb 10, 2026 •

edited

Loading

Uh oh!

JManion32 left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

Rkoester47 commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why is this Change Important & Necessary?

What is the New Behavior?

What steps should a reviewer take to reproduce or test the bug or new feature?

Automated Testing & Documentation

Other information

Uh oh!

codecov bot commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

aconfo left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JManion32 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dagemcn commented Feb 6, 2026

Uh oh!

dagemcn left a comment

Choose a reason for hiding this comment

Uh oh!

JManion32 commented Feb 6, 2026

Uh oh!

Rkoester47 commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JManion32 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Rkoester47 commented Jan 27, 2026 •

edited

Loading

codecov bot commented Jan 27, 2026 •

edited

Loading

aconfo left a comment •

edited

Loading

Rkoester47 commented Feb 10, 2026 •

edited

Loading