[Feature:InstructorUI] Give Instructor Read-Only DockerUI page#12346
[Feature:InstructorUI] Give Instructor Read-Only DockerUI page#12346
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #12346 +/- ##
============================================
- Coverage 21.69% 21.67% -0.03%
- Complexity 9617 9623 +6
============================================
Files 268 268
Lines 36115 36171 +56
Branches 478 486 +8
============================================
+ Hits 7836 7840 +4
- Misses 27805 27849 +44
- Partials 474 482 +8
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Rkoester47
left a comment
There was a problem hiding this comment.
I followed the steps outlined in the PR for my testing and found that the changes are behaving as intended. While logged in as manne, I was able to view the DockerUI page but had no ability to edit anything. When signed in as instructor, I was able to access the same DockerUI page but had full access to edit items on the page.
hyeenaa
left a comment
There was a problem hiding this comment.
Before fixes, a sample instructor , (manne) cannot access dockerui on the main page at all, but faculty can.
After testing the new branch, the sample instructor can indeed look at the docker ui, but cannot edit details, as outlined in the fixes.
cjreed121
left a comment
There was a problem hiding this comment.
Code looks good to me. Have not tested locally. Thanks for making changes
Why is this Change Important & Necessary?
Fix #12345
Instructors need to be able to see what Docker containers are available for autograding. We can do this by giving instructors access to DockerUI, but don't allow them to add or remove dockerUI as those are for faculty members
What is the New Behavior?
Instructors can access DockerUI, but cannot update machines and cannot add images to capabilities.
Instructor:
What steps should a reviewer take to reproduce or test the bug or new feature?
Test that instructors (manne for sample course) can access dockerui and faculty (instructor) can edit stuff in dockerUI
Automated Testing & Documentation
Cypress test to double check that manne cannot access anything in dockerui is included
Other information
Barb, the text for not being able to add capabilities to images is "You do not have permission to add images to capabilities. Please contact a faculty member or sysadmin for assistance." Adjust this wording (or request other ones) as needed