[Refactor:InstructorUI] PHPStan 2.1.32 Compatibility Refinements#12284
Merged
williamjallen merged 5 commits intomainfrom Jan 3, 2026
Merged
[Refactor:InstructorUI] PHPStan 2.1.32 Compatibility Refinements#12284williamjallen merged 5 commits intomainfrom
williamjallen merged 5 commits intomainfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #12284 +/- ##
=========================================
Coverage 21.69% 21.69%
+ Complexity 9618 9617 -1
=========================================
Files 268 268
Lines 36113 36115 +2
Branches 478 478
=========================================
+ Hits 7835 7836 +1
- Misses 27804 27805 +1
Partials 474 474
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Contributor
|
Why are we creating a separate PR for this rather than pushing directly to #12260? |
Member
|
@JManion32 I personally like to merge PHPStan bumps with only changes to the baseline, and then create follow-up PRs to address any new errors. That way, a PHPStan version bump will never break main. I'll handle regenerating the baseline and then removing the baseline errors in this PR. |
williamjallen
approved these changes
Jan 3, 2026
Aaditya-2407
pushed a commit
to Aaditya-2407/Submitty
that referenced
this pull request
Jan 5, 2026
…mitty#12284) ### Why is this Change Important & Necessary? <!-- Include any GitHub issue that is fixed/closed using "Fixes #<number>" or "Closes #<number>" syntax. Alternately write "Partially addresses #<number>" or "Related to #<number>" as appropriate. --> As a continuation of Submitty#12150, before merging Submitty#12260, it is necessary to ensure that all of the code is compatible with the new version of PHPStan. ### What is the New Behavior? <!-- Include before & after screenshots/videos if the user interface has changed. --> PHPStan 2.1.32 check now passes after this change. ### What steps should a reviewer take to reproduce or test the bug or new feature? 1. Checkout Submitty#12260 and then PHPStan ([documentation](https://submitty.org/developer/testing/linting_static_analysis)) 2. Run `git diff main phpstan-upgrade-prep-2 | git apply` to apply the changes from this branch 3. Run PHPStan again and the test will pass --------- Co-authored-by: William Allen <william.j.allen24@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this Change Important & Necessary?
As a continuation of #12150, before merging #12260, it is necessary to ensure that all of the code is compatible with the new version of PHPStan.
What is the New Behavior?
PHPStan 2.1.32 check now passes after this change.
What steps should a reviewer take to reproduce or test the bug or new feature?
git diff main phpstan-upgrade-prep-2 | git applyto apply the changes fromthis branch