[Bugfix:TAGrading] Persistent Full Left Column#12224
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #12224 +/- ##
=========================================
Coverage 21.71% 21.71%
Complexity 9612 9612
=========================================
Files 268 268
Lines 36070 36070
Branches 475 475
=========================================
Hits 7832 7832
Misses 27767 27767
Partials 471 471
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
oh boy not this again |
If I remember correctly, this was a fix to fullScreenMode being shown on instructor rubric. I think this issue got fixed and this bug got made in the same PR. |
|
Ohhhhhh i remember now. I mistyped |
Why is this Change Important & Necessary?
Fixes #12221
The
side-by-side, taller leftpanel option in the TAGrading interface could be successfully toggled, but was not persistent upon page reload. This issue only affected non-instructors because the initialization logic for the interface was checking that both the user preference for the panel was true, and that the silent edit checkbox existed on the DOM, which is a feature for instructors only.What is the New Behavior?
Removed the second check, and now the initialization logic works as expected, making the user's left column preference persistent. I can't think of how silent regrading and panel preferences are/were related, perhaps its just the result of many years of changes to the TA grading code.
What steps should a reviewer take to reproduce or test the bug or new feature?
Automated Testing & Documentation
There are no tests for this change. It may be a good idea to make a Cypress test in a future PR for all of these preferences to ensure they are working as expected.
Other information
This is not a breaking change.