[Feature:RainbowGrades] Rainbow Grades Nightly Builds Banner#12139
[Feature:RainbowGrades] Rainbow Grades Nightly Builds Banner#12139
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #12139 +/- ##
============================================
- Coverage 21.71% 21.71% -0.01%
- Complexity 9611 9612 +1
============================================
Files 268 268
Lines 36068 36073 +5
Branches 475 475
============================================
Hits 7832 7832
- Misses 27765 27770 +5
Partials 471 471
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
RyanStyron
left a comment
There was a problem hiding this comment.
Looks good to me. One minor suggestion: rename "nightly builds" in the warning message to "Nightly Builds" to be more consistent with the documentation. Also, please address the Lint failure.
RyanStyron
left a comment
There was a problem hiding this comment.
Please resolve Lint failures, but looks great otherwise.
|
@Rkoester47 I think this message should appear a bit lower on the page, perhaps next to the 'generate grade summaries' button. After all, this nightly build feature hopefully means they will less frequently need to do the manual generate grade summaries + additional steps to push grades to students. I am worried if we make it smaller and put it close to the generate grade summaries button, this banner will look like a button except its not clickable, which could be confusing. |
Also changed the colors to use Submitty variables instead of hard coded colors.
|
@Rkoester47 |
Why is this Change Important & Necessary?
Partially Fixes #11599 with added customization for archived courses to come in a future PR.
Currently, there is no indication of the status of Rainbow Grades nightly builds, besides going to the actual toggle for this feature and seeing if it is checked off.
What is the New Behavior?
(Firefox)
The message indicating the status of Rainbow Grades Nightly Builds is now displayed under the "Generate Grade Summaries" button, just below the "Last ran" information. This way, the message is not crowding the title, and instead provides helpful information in the body of the page.
The previous version of the banner is currently commented out until the final format for this message is decided.
What steps should a reviewer take to reproduce or test the bug or new feature?
Go to the Submitty test site, toggle Nightly Builds in Course Settings and go to the Grades Configuration page each time to see if the info message appropriately displays whether the nightly builds feature is enabled or disabled.
Automated Testing & Documentation
Other information
This is not a breaking change.