[Bugfix:Forum] Empty forum More dropdown fix#12129
Merged
bmcutler merged 3 commits intoSubmitty:mainfrom Nov 12, 2025
Merged
Conversation
Member
|
@Legkobyt |
Contributor
Author
Contributor
Author
|
@bmcutler, could you please review the changes |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12129 +/- ##
=========================================
Coverage 21.73% 21.73%
Complexity 9598 9598
=========================================
Files 268 268
Lines 36006 36006
Branches 475 475
=========================================
Hits 7827 7827
Misses 27708 27708
Partials 471 471
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
RyanStyron
requested changes
Oct 15, 2025
Contributor
RyanStyron
left a comment
There was a problem hiding this comment.
The changes adequately address the linked issue. Great work. Please correct the failed tests prior to approval.
RyanStyron
requested changes
Oct 28, 2025
Contributor
RyanStyron
left a comment
There was a problem hiding this comment.
Please update the title so that the respective test will pass.
Contributor
Author
Could you please run jobs once again @RyanStyron |
RyanStyron
approved these changes
Oct 28, 2025
Contributor
Author
|
@RyanStyron, Could you, please, rerun pipeline if Ansible dependencies were updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this Change Important & Necessary?
Bug has been fixed -> Empty forum instructor view More dropdown fix #12001
This is how it looks after bugfix
Empty Discussion forum 1920x1080
Empty Discussion forum 3072x1620
Not empty Discussion forum 3072x1620
Screenshots were take at Chrome 141.0.7390.54
What steps should a reviewer take to reproduce or test the bug or new feature?
Follow steps as provided in bug report