[DevDependency] Bump phpstan/phpstan from 2.1.22 to 2.1.29 in /site#12093
Closed
dependabot[bot] wants to merge 1 commit intomainfrom
Closed
[DevDependency] Bump phpstan/phpstan from 2.1.22 to 2.1.29 in /site#12093dependabot[bot] wants to merge 1 commit intomainfrom
dependabot[bot] wants to merge 1 commit intomainfrom
Conversation
lavalleeale
approved these changes
Oct 14, 2025
Contributor
lavalleeale
left a comment
There was a problem hiding this comment.
Only one change was necessary for this new version of phpstan, and it has been made
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12093 +/- ##
=========================================
Coverage 21.68% 21.68%
Complexity 9598 9598
=========================================
Files 268 268
Lines 36620 36620
Branches 475 475
=========================================
Hits 7941 7941
Misses 28208 28208
Partials 471 471
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Member
|
@dependabot rebase |
Contributor
Author
|
Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry! If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request |
Member
|
@lavalleeale We typically don't make code changes in dependency updates unless necessary. Instead, it's better to add the new errors to the baseline and optionally create a separate PR to fix them. |
Member
|
@dependabot recreate |
b20e77a to
7dbe07a
Compare
7dbe07a to
4c2f55a
Compare
Bumps [phpstan/phpstan](https://github.com/phpstan/phpstan) from 2.1.22 to 2.1.29. - [Release notes](https://github.com/phpstan/phpstan/releases) - [Changelog](https://github.com/phpstan/phpstan/blob/2.1.x/CHANGELOG.md) - [Commits](phpstan/phpstan@2.1.22...2.1.29) --- updated-dependencies: - dependency-name: phpstan/phpstan dependency-version: 2.1.29 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
4c2f55a to
01fe044
Compare
Contributor
Author
|
Superseded by #12166. |
bmcutler
pushed a commit
that referenced
this pull request
Dec 15, 2025
### Why is this Change Important & Necessary? <!-- Include any GitHub issue that is fixed/closed using "Fixes #<number>" or "Closes #<number>" syntax. Alternately write "Partially addresses #<number>" or "Related to #<number>" as appropriate. --> Before we can merge #12093 (superseded by #12260), we need to make sure that all of our code is compatible with the new version of phpstan, and this was the one place that our code has started failing. ### What is the New Behavior? <!-- Include before & after screenshots/videos if the user interface has changed. --> Phpstan 2.1.32 now passes after this change. ### What steps should a reviewer take to reproduce or test the bug or new feature? 1. Checkout #12260 and run `composer install` and then phpstan and view that 1 error is detected 2. Run `git diff main phpstan-prep | git apply` to get the changes from this branch 3. Run phpstan again and it shall pass ### Automated Testing & Documentation <!-- Is this feature sufficiently tested by unit tests and end-to-end tests? If this PR does not add/update the necessary automated tests, write a new GitHub issue and link it below. Is this feature sufficiently documented on submitty.org? Link related PRs or new GitHub issue to update documentation. --> ### Other information <!-- Is this a breaking change? Does this PR include migrations to update existing installations? Are there security concerns with this PR? --> --------- Co-authored-by: Ryan Styron <ryanstyron1220@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps phpstan/phpstan from 2.1.22 to 2.1.29.
Release notes
Sourced from phpstan/phpstan's releases.
... (truncated)
Commits
d618573PHPStan 2.1.2934e54beUpdate errors identifiers1611a88Updated PHPStan to commit 1611a884837df994eb91bc6fdf23c661c4ce361fe93ad8dRename branch9adbff9Updated PHPStan to commit 9adbff9b289197cff7817f12b7477f32728d55c764c1547Custom Composer source for cloningphpstan/phpstan17f859dRe-enable PHPCS4664230Update baselinesfad1c40Remove tests about polyfills217fca4Re-enable moreDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)