Skip to content

[Bugfix:CourseMaterials] Fix Course Materials Header Wrap#12067

Merged
bmcutler merged 7 commits intomainfrom
course-materials-wrap-fix
Sep 22, 2025
Merged

[Bugfix:CourseMaterials] Fix Course Materials Header Wrap#12067
bmcutler merged 7 commits intomainfrom
course-materials-wrap-fix

Conversation

@Rkoester47
Copy link
Copy Markdown
Contributor

@Rkoester47 Rkoester47 commented Sep 16, 2025 •
edited by JManion32
Loading

Why is this Change Important & Necessary?

Currently, there is an issue that causes the Course Materials page header to wrap improperly. Additionally, the position and spacing of the key on this page was awkwardly centered, and somewhat cramped. These changes address the wrapping issue, and improve the appearance of the key.

This change Fixes #12002.

What is the New Behavior?

  1. The Course Materials header should does not wrap below the blue action buttons.
  2. The key is located under the header, to the left of the page.
  3. There is additional padding between the key and the items in the course materials files.

Before( on Chrome):
476817419-8d655de7-29a2-4004-a0dc-5c672d1bfdc6

After (on chrome):
After

After (Mobile):
image

What steps should a reviewer take to reproduce or test the bug or new feature?

  1. Go to the Submitty test site -> login as instructor -> go to Sample -> Course Materials
  2. Check to see if the "Course Materials" header still wraps below the blue buttons, as in the example image. The header should now be level with the blue action buttons, and the key should be below the header.
    Ideally, this should be tested across multiple browsers and themes.

Other information

This is not a breaking change.

@github-project-automation github-project-automation bot moved this to Seeking Reviewer in Submitty Development Sep 16, 2025
@automateprojectmangement automateprojectmangement bot moved this from Seeking Reviewer to Work in Progress in Submitty Development Sep 16, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 16, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 21.69%. Comparing base (25d7aee) to head (ce2f46f).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main   #12067   +/-   ##
=========================================
  Coverage     21.69%   21.69%           
  Complexity     9587     9587           
=========================================
  Files           268      268           
  Lines         36591    36591           
  Branches        475      475           
=========================================
  Hits           7940     7940           
  Misses        28180    28180           
  Partials        471      471
Flag Coverage Δ
autograder 21.39% <ø> (ø)
js 2.07% <ø> (ø)
migrator 100.00% <ø> (ø)
php 20.71% <ø> (ø)
python_submitty_utils 80.08% <ø> (ø)
submitty_daemon_jobs 90.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Rkoester47 Rkoester47 marked this pull request as ready for review September 17, 2025 02:43
@automateprojectmangement automateprojectmangement bot moved this from Work in Progress to Seeking Reviewer in Submitty Development Sep 17, 2025
JManion32
JManion32 requested changes Sep 19, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@JManion32 JManion32 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, code is more intuitive and the UI is now consistent across multiple browsers on varying screen sizes. One small change I noticed when on mobile scale:

Since we have multiple instances of this div:
<div class="action-buttons" style="float: right; margin-bottom: 20px;">
It doesn't wrap cleanly. To fix, take the Mark all viewed anchor out of there and remove the div, then add that anchor to the top of the other action buttons div with the other 3 anchors.

Before:
image

After:
image

Once that is addressed, I am ready to approve!

@github-project-automation github-project-automation bot moved this from Seeking Reviewer to Work in Progress in Submitty Development Sep 19, 2025
JManion32
JManion32 approved these changes Sep 19, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@JManion32 JManion32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is significantly more intuitive, and UI is consistent on different browsers and screen sizes. Great work!

@github-project-automation github-project-automation bot moved this from Work in Progress to Awaiting Maintainer Review in Submitty Development Sep 19, 2025
@bmcutler bmcutler merged commit ca9ef0e into main Sep 22, 2025
24 of 26 checks passed
@bmcutler bmcutler deleted the course-materials-wrap-fix branch September 22, 2025 02:24
@github-project-automation github-project-automation bot moved this from Awaiting Maintainer Review to Done in Submitty Development Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JManion32 JManion32 JManion32 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

Submitty Development
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

course materials view for instructor wraps oddly

3 participants

@Rkoester47 @JManion32 @bmcutler