[Bugfix:Forum] Save chatroom in db on delete#11858
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11858 +/- ##
============================================
- Coverage 20.70% 20.70% -0.01%
- Complexity 9191 9194 +3
============================================
Files 265 265
Lines 35215 35220 +5
Branches 458 458
============================================
Hits 7292 7292
- Misses 27469 27474 +5
Partials 454 454
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
jeffrey-cordero
approved these changes
Jul 9, 2025
Contributor
jeffrey-cordero
left a comment
There was a problem hiding this comment.
Changes look good. I recommend making an issue to add unit testing to the ChatroomController.php file, as this would add a bit more complexity to the feature. A future addition of viewing deleted chat rooms as an instructor would also be a good follow-up for this.
williamschen23
pushed a commit
that referenced
this pull request
Jul 18, 2025
### Why is this Change Important & Necessary? We want to see chatroom information in database so that professors can check chatrooms even after they're deleted. Before deleting a chatroom would delete it from db. ### What is the New Behavior? Now a chatroom is kept in db, but a parameter labeled is_deleted is switched from false to true, which prevents the chatroom from showing. ### What steps should a reviewer take to reproduce or test the bug or new feature? On main, create and delete a chat. Then, go to sql toolbox and query SELECT * FROM chatrooms. That chatroom should not exist in db anymore. Switch to this branch, and do the same. The chatroom should still show, but with a new column labelled "is_deleted" set to true instead of false. ### Automated Testing & Documentation Deleting chats will be tested once #11818 is merged --------- Co-authored-by: Alex Lavallee <73203142+lavalleeale@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this Change Important & Necessary?
We want to see chatroom information in database so that professors can check chatrooms even after they're deleted. Before deleting a chatroom would delete it from db.
What is the New Behavior?
Now a chatroom is kept in db, but a parameter labeled is_deleted is switched from false to true, which prevents the chatroom from showing.
What steps should a reviewer take to reproduce or test the bug or new feature?
On main, create and delete a chat. Then, go to sql toolbox and query SELECT * FROM chatrooms. That chatroom should not exist in db anymore. Switch to this branch, and do the same. The chatroom should still show, but with a new column labelled "is_deleted" set to true instead of false.
Automated Testing & Documentation
Deleting chats will be tested once #11818 is merged