Update elFinderVolumeSFTPphpseclib.class.php #3483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, this class does not work with symlinks at all. Permissions also don't work properly. Using Flysystem is not an option for me because that requires PHP v8. I ended up creating my own `SFTP3phpseclib.class.php`. I have edited this file with some of the changes I made to get symlinks sort of working. I am still testing it so this is just a start. It took me a long time to figure out how to get symlinks to show up so maybe this will help others struggling with this. I am using phpseclib v3 so I only tested these changes with that library. I made a bunch of changes to get permissions working properly. I may include that in a separate pull request after I test it more.
Member
|
@sdwru thank you! I'm sorry to be late. |
abdul-kaioum
pushed a commit
to Bit-Apps-Pro/elFinder
that referenced
this pull request
Oct 22, 2023
Currently, this class does not work with symlinks at all. Permissions also don't work properly. Using Flysystem is not an option for me because that requires PHP v8. I ended up creating my own `SFTP3phpseclib.class.php`. I have edited this file with some of the changes I made to get symlinks sort of working. I am still testing it so this is just a start. It took me a long time to figure out how to get symlinks to show up so maybe this will help others struggling with this. I am using phpseclib v3 so I only tested these changes with that library. I made a bunch of changes to get permissions working properly. I may include that in a separate pull request after I test it more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, this class does not work with symlinks at all. Permissions also don't work properly. Using Flysystem is not an option for me because that requires PHP v8. Older flysystem requires PHP v7.4 which is also not an option for me since I am stuck with v7.3 for now.
I ended up creating my own
SFTP3phpseclib.class.php. I have edited this file with some of the changes I made to get symlinks sort of working. I am still testing it so this is just a start. It took me a long time to figure out how to get symlinks to show up so maybe this will help others struggling with this. I am using phpseclib v3 so I only tested these changes with that library.I also made a bunch of changes to get permissions working properly. I may include that in a separate pull request after I test it more.