Skip to content

[fix][test] final shutdown executor when the class(PerformanceProducer) is destroyed#7

Open
StevenLuMT wants to merge 1 commit into
masterfrom
master_executorShutdown
Open

[fix][test] final shutdown executor when the class(PerformanceProducer) is destroyed#7
StevenLuMT wants to merge 1 commit into
masterfrom
master_executorShutdown

Conversation

@StevenLuMT

@StevenLuMT StevenLuMT commented Mar 24, 2023

Copy link
Copy Markdown
Owner

Motivation

When the class(PerformanceProducer) destroy, shutdown the executor

Modifications

final shutdown executor when the class(PerformanceProducer) is destroyed

Verifying this change

  • Make sure that the change passes the CI checks.
    This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

Check the box below or label this PR directly.

Need to update docs?

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: #7

@StevenLuMT StevenLuMT changed the title [fix][testclient] final shutdown executor in main [fix][test] final shutdown executor in main Mar 24, 2023
@StevenLuMT StevenLuMT closed this Mar 24, 2023
@StevenLuMT StevenLuMT reopened this Mar 24, 2023
@StevenLuMT StevenLuMT force-pushed the master_executorShutdown branch from 91b5709 to 1318bfe Compare March 27, 2023 06:54
@StevenLuMT StevenLuMT force-pushed the master_executorShutdown branch from 1318bfe to 388281d Compare March 28, 2023 07:40
@StevenLuMT StevenLuMT changed the title [fix][test] final shutdown executor in main [fix][test] final shutdown executor when the class(PerformanceProducer) is destroyed Mar 28, 2023
@StevenLuMT

Copy link
Copy Markdown
Owner Author

/pulsarbot run-failure-checks

@github-actions

Copy link
Copy Markdown

The pr had no activity for 30 days, mark with Stale label.

@github-actions github-actions Bot added the Stale label Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant