Check params_file arg, and use default if it has no slam_toolbox params#368
Conversation
This is a workaround to ros-navigation/navigation2#2243 to keep foxy API stable by not changing the params_file name.
|
@SteveMacenski As discussed on ros-navigation/navigation2#2243 this is the workaround for foxy. I've added a LogInfo when this workaround is applied, so users have some clue that their
|
slam_toolbox/launch/__init__.py
Outdated
| @@ -0,0 +1,15 @@ | |||
| # Copyright (c) 2021 PAL Robotics S.L. | |||
There was a problem hiding this comment.
This project is LGPLv2.1 due to the use of openkarto, please use the appropriate license header (or dont include like the others)
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at |
There was a problem hiding this comment.
We have a dep on nav2_map_server, you can make a dep on nav2_common and add this to that in foxy + use it from there.
|
Just licensing / not copying files around too too much (and licensing is dealt with by just moving it back to nav2_common) |
|
Moved the file to nav2_common as suggested. See ros-navigation/navigation2#2257. |
SteveMacenski
left a comment
There was a problem hiding this comment.
Did you test with the import from nav2_common?
|
Yes, even removed workspace and recompiled to make sure of it. |
…ms (SteveMacenski#368) * Check params_file arg, and use default if it has no slam_toolbox params This is a workaround to ros-navigation/navigation2#2243 to keep foxy API stable by not changing the params_file name. * Use has_node_params in nav2_common
Basic Info
Description
This is a workaround to ros-navigation/navigation2#2243 to keep foxy API stable by not changing the params_file name.