Fix 165741 #5
Merged
Fix 165741 #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skia is moving its [pathops code around](http://review.skia.org/999760). In http://review.skia.org/1001216 we added a new set of filegroups to facilitate this. This updates the BUILD.gn rules to use those new groups. ## Pre-launch Checklist - [ x ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ x ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ x ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ x ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ x ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ x ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ x ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
…70412) Roll Skia from 910070084066 to b78fdc3ba26b (33 revisions) https://skia.googlesource.com/skia.git/+log/910070084066..b78fdc3ba26b 2025-06-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 3d47c8a32f07 to 9d27097cc7dd (14 revisions) 2025-06-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from a857503547cb to 155f095a8c63 (2 revisions) 2025-06-11 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2025-06-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from d9842c624bd1 to e16ef854c44f (6 revisions) 2025-06-10 danieldilan@google.com Reland "[png] Simplify extra endian transform for SkPngEncode" 2025-06-10 lukasza@chromium.org [rust png] Reset `fIncrementalDecodingState` after nonrecoverable errors 2025-06-10 jreck@google.com Add host_supported to libskia_skcms 2025-06-10 syoussefi@google.com [graphite][vulkan] Disable MSAA on Intel 2025-06-10 robertphillips@google.com [graphite] Fold ColorFilters and constant Shaders into a Solid Color 2025-06-10 mike@reedtribe.org Use SkSpan in SkTextBlob API 2025-06-10 mike@reedtribe.org Use SkSpan for dashing 2025-06-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from fe4617b72605 to d9842c624bd1 (5 revisions) 2025-06-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 3a15fab06cff to a787766551aa (7 revisions) 2025-06-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 3c7e00b52946 to 29821d9a17ae (13 revisions) 2025-06-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from f3220117fc62 to 3d47c8a32f07 (12 revisions) 2025-06-09 ccameron@chromium.org HDR v2: Add no-op OOTF parameters to sk_color_space_transform 2025-06-09 syoussefi@google.com [vulkan] Require Vulkan 1.1 in Ganesh 2025-06-09 mike@reedtribe.org Use size_t for font/typeface return values (to match span's) 2025-06-09 syoussefi@google.com [graphite][vulkan] Use VK_EXT_graphics_pipeline_library 2025-06-09 thomsmit@google.com Reland "[graphite] Fix clamping bug on Intel UHD 630." 2025-06-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from d5d3942f4b8f to fe4617b72605 (1 revision) 2025-06-09 jreck@google.com Add dng sdk 1.4 -> 1.7.1 migration compat 2025-06-09 mike@reedtribe.org Use SkSpan in read and write buffers 2025-06-09 mike@reedtribe.org Use new span APIS (time to dogfood) 2025-06-09 skia-autoroll@skia-public.iam.gserviceaccount.com Manual Roll vulkan-deps from 1c3b39ad6dc0 to d5d3942f4b8f (14 revisions) 2025-06-09 bungeman@google.com Remove many deprecated declarations 2025-06-09 syoussefi@google.com [vulkan] Apply RelaxedPrecision to OpImageSampleImplicitLod 2025-06-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from db9624073324 to 3a15fab06cff (4 revisions) 2025-06-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 11dc1b167af4 to a857503547cb (1 revision) 2025-06-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 3bbfa4528971 to 3c7e00b52946 (5 revisions) 2025-06-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 63ca6919b752 to f3220117fc62 (31 revisions) 2025-06-08 ccameron@chromium.org SkColorSpaceXformSteps: Start to add support for HLG and PQ 2025-06-08 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC jsimmons@google.com,kjlubick@google.com,michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 ...
…r#170430) https://dart.googlesource.com/sdk.git/+log/6290dfd1d88a..b569246d64bc 2025-06-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.9.0-220.0.dev 2025-06-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.9.0-219.0.dev 2025-06-11 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.9.0-218.0.dev 2025-06-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.9.0-217.0.dev If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter Please CC dart-vm-team@google.com,jsimmons@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Skia is updating its public APIs to use spans instead of rawptr + count. This is a temporary flag to enable the old style entry points while clients are being updated. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
## Description This PR fixes the touch target (and Semantic bounds) for day buttons shown in the date picker calendar mode. To do so it changes the dialog size and buttons padding to conform to the M3 spec, see https://m3.material.io/components/date-pickers/specs#2d53890e-a08f-4c63-a0d9-abd9e95b4245 ### Before  ### After  ## Related Issue Fixes [DateTimePicker date buttons fail touch target size accessibility checks](flutter#158325) ## Tests Adds 1 test. ## Implementation choice This PR targets only M3 and portrait mode: - M3 because M2 dialog picker was not designed to be accessible (day buttons are 40 pixels). - Portrait mode only, because there are no specification for the landscape mode and existing implementations (Google Calendar, Compose) vary. I will open a separate issue to discuss a possible solution for landscape mode.
We now avoid a temporary path object and feed arc paths directly to the renderer in all `DrawArc` cases.
This PR was generated by `flutter update-packages --force-upgrade`.
<!-- Thanks for filing a pull request! Reviewers are typically assigned within a week of filing a request. To learn more about code review, see our documentation on Tree Hygiene: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md --> In flutter#170084, this little change was missed ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
…Safari (flutter#170022) Manually trigger an `input` event to trigger the `handleChange` handler in the text input element. In Safari for MacOS 15.5, this workaround is now required. Fixes flutter#169282 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --------- Co-authored-by: Mouad Debbar <mdebbar@google.com>
flutter#170262) This change reworks how preview detection is performed to allow for identifying libraries which contain compile-time errors or transitive dependencies with compile-time errors. Previously, introducing a compile-time error into a preview containing library's dependency chain would result in the preview environment no longer being updated due to a failed compilation during hot reload. Users would first need to know to fix the compilation error before being able to make updates to previews. With this change, the preview detector builds and maintains a dependency graph, propagating errors from libraries to their upstream dependencies. If a file containing a preview would fail to compile, it is no longer inserted into the widget preview environment. In its place, an error message is displayed informing the user that there's a compilation error in a library that needs to be fixed first. This change needs some follow up work to create a proper UI for displaying the compilation error messaging, batch processing of bulk file system operations (e.g., directory deletion) to avoid performance issues, and some refactoring. Work towards flutter#166430
Sten435
pushed a commit
that referenced
this pull request
Nov 10, 2025
This test passes when run locally as instructed in the README for the devicelab ``` ../../bin/cache/dart-sdk/bin/dart bin/test_runner.dart test -t android_verified_input_test ``` but fails on CI: https://ci.chromium.org/ui/p/flutter/builders/staging/Linux_pixel_7pro%20android_verified_input_test/106/overview ``` [2025-11-03 11:08:04.090018] [STDOUT] stdout: [ ] Original error: ext.flutter.driver: (-32000) Service connection disposed [2025-11-03 11:08:04.090156] [STDOUT] stdout: [ ] Original stack trace: [2025-11-03 11:08:04.090199] [STDOUT] stdout: [ ] #0 new _OutstandingRequest (package:vm_service/src/vm_service.dart:268:34) [2025-11-03 11:08:04.091572] [STDOUT] stdout: [ ] #1 VmService._call.<anonymous closure> (package:vm_service/src/vm_service.dart:1950:25) [2025-11-03 11:08:04.091647] [STDOUT] stdout: [ ] #2 VmService._call (package:vm_service/src/vm_service.dart:1962:8) [2025-11-03 11:08:04.091674] [STDOUT] stdout: [ ] #3 VmService.callServiceExtension (package:vm_service/src/vm_service.dart:1901:14) [2025-11-03 11:08:04.091693] [STDOUT] stdout: [ ] #4 VMServiceFlutterDriver.sendCommand (package:flutter_driver/src/driver/vmservice_driver.dart:327:12) [2025-11-03 11:08:04.091713] [STDOUT] stdout: [ ] #5 FlutterDriver.requestData (package:flutter_driver/src/driver/driver.dart:573:13) [2025-11-03 11:08:04.091733] [STDOUT] stdout: [ ] #6 main.<anonymous closure> (file:///opt/s/w/ir/x/w/rc/tmpv6pcbna2/flutter%20sdk/dev/integration_tests/android_verified_input/test_driver/main_test.dart:28:57) [2025-11-03 11:08:04.091750] [STDOUT] stdout: [ ] <asynchronous suspension> [2025-11-03 11:08:04.091767] [STDOUT] stdout: [ ] #7 Declarer.test.<anonymous closure>.<anonymous closure> (package:test_api/src/backend/declarer.dart:242:9) [2025-11-03 11:08:04.091784] [STDOUT] stdout: [ ] <asynchronous suspension> [2025-11-03 11:08:04.092408] [STDOUT] stdout: [ ] #8 Declarer.test.<anonymous closure> (package:test_api/src/backend/declarer.dart:240:7) [2025-11-03 11:08:04.092472] [STDOUT] stdout: [ ] <asynchronous suspension> [2025-11-03 11:08:04.092502] [STDOUT] stdout: [ ] #9 Invoker._waitForOutstandingCallbacks.<anonymous closure> (package:test_api/src/backend/invoker.dart:282:9) ``` Try copying this configuration used by other tests as a speculative fix. I can't get this test to kick off in presubmit, so I suppose we will just try this. The test is marked bringup anyways so it won't block the tree if this doesn't help. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --------- Co-authored-by: Gray Mackall <mackall@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.