[BugFix] Handle parquet exception caused by wrong s3 configuration#23606
Merged
stephen-shelby merged 4 commits intoStarRocks:mainfrom May 18, 2023
Merged
[BugFix] Handle parquet exception caused by wrong s3 configuration#23606stephen-shelby merged 4 commits intoStarRocks:mainfrom
stephen-shelby merged 4 commits intoStarRocks:mainfrom
Conversation
Signed-off-by: Letian Jiang <letian.jiang@outlook.com>
Smith-Cruise
previously approved these changes
May 18, 2023
stephen-shelby
approved these changes
May 18, 2023
stephen-shelby
approved these changes
May 18, 2023
stephen-shelby
previously approved these changes
May 18, 2023
Youngwb
reviewed
May 18, 2023
| _writer.release(); | ||
|
|
||
| auto st = Status::IOError(fmt::format("{}: {}", "flush rowgroup error", e.what())); | ||
| LOG(WARNING) << st; |
Contributor
There was a problem hiding this comment.
add _chunk_writer.reset(); before return?
7fd2491
Youngwb
approved these changes
May 18, 2023
Smith-Cruise
approved these changes
May 18, 2023
stephen-shelby
approved these changes
May 18, 2023
Moonm3n
pushed a commit
to Moonm3n/starrocks
that referenced
this pull request
May 23, 2023
…tarRocks#23606) Using a wrong s3 configuration (ak/sk/endpoint) will not be checked until the parquet writer tries to flush buffered data into the output stream. In this case, `BufferedPageWriter.Close()` throws an exception, which should be handled. Moreover, the deconstructor of `ParquetFileWriter` causes SIGSEGV. We have to mark the file writer as closed and release its ownership to avoid calling its dtor. Signed-off-by: Letian Jiang <letian.jiang@outlook.com> Signed-off-by: Moonm3n <saxonzhan@gmail.com>
wxl24life
pushed a commit
to wxl24life/starrocks
that referenced
this pull request
May 25, 2023
…tarRocks#23606) Using a wrong s3 configuration (ak/sk/endpoint) will not be checked until the parquet writer tries to flush buffered data into the output stream. In this case, `BufferedPageWriter.Close()` throws an exception, which should be handled. Moreover, the deconstructor of `ParquetFileWriter` causes SIGSEGV. We have to mark the file writer as closed and release its ownership to avoid calling its dtor. Signed-off-by: Letian Jiang <letian.jiang@outlook.com>
16 tasks
abc982627271
pushed a commit
to abc982627271/starrocks
that referenced
this pull request
Jun 5, 2023
…tarRocks#23606) Using a wrong s3 configuration (ak/sk/endpoint) will not be checked until the parquet writer tries to flush buffered data into the output stream. In this case, `BufferedPageWriter.Close()` throws an exception, which should be handled. Moreover, the deconstructor of `ParquetFileWriter` causes SIGSEGV. We have to mark the file writer as closed and release its ownership to avoid calling its dtor. Signed-off-by: Letian Jiang <letian.jiang@outlook.com>
16 tasks
dirtysalt
pushed a commit
that referenced
this pull request
Jun 20, 2023
Fixes #23606, where memory leaks are introduced by `_chunk_writer->release()` The modification on Arrow is to make sure `RowGroupSerializer::column_writers_` is cleaned up even if exception throws. You may refer apache/arrow#35520 for more details. Signed-off-by: Letian Jiang <letian.jiang@outlook.com>
southernriver
pushed a commit
to southernriver/starrocks
that referenced
this pull request
Nov 28, 2023
…tarRocks#23606) Using a wrong s3 configuration (ak/sk/endpoint) will not be checked until the parquet writer tries to flush buffered data into the output stream. In this case, `BufferedPageWriter.Close()` throws an exception, which should be handled. Moreover, the deconstructor of `ParquetFileWriter` causes SIGSEGV. We have to mark the file writer as closed and release its ownership to avoid calling its dtor. Signed-off-by: Letian Jiang <letian.jiang@outlook.com> (cherry picked from commit 672e3f5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Summary:
Fixes # (issue)
Using a wrong s3 configuration (ak/sk/endpoint) will not be checked until the parquet writer tries to flush buffered data into the output stream. In this case,
BufferedPageWriter.Close()throws an exception, which should be handled.Moreover, the deconstructor of
ParquetFileWritercauses SIGSEGV. We have to mark the file writer as closed and release its ownership to avoid calling its dtor.What type of PR is this:
Checklist:
Bugfix cherry-pick branch check: