Fix zipp version to fix ST2 CI issues.#6015
Merged
cognifloyd merged 2 commits intomasterfrom Aug 19, 2023
Merged
Conversation
nzlosh
approved these changes
Aug 18, 2023
arm4b
approved these changes
Aug 18, 2023
jk464
pushed a commit
to jk464/st2
that referenced
this pull request
Aug 23, 2023
* Fix zipp * Missed changelog
jk464
pushed a commit
to jk464/st2
that referenced
this pull request
Aug 23, 2023
* Fix zipp * Missed changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current CI builds are failing when performing the st2client_install_check, see https://github.com/StackStorm/st2/actions/runs/5897223026/job/15996511713
Changes from when it first failed were zipp version got incremented, and that is where error is.
Fixed zipp version in requirements used by st2client and re-generated requirements.txt files and pants lock files.
Ran make .st2client_install_check manually to ensure that it now passes and pulls in a valid zipp version.