Skip to content

Allows GitLab SSH URLs on pack actions#5050

Merged
amanda11 merged 11 commits intoStackStorm:masterfrom
lcsaa:allow_gitlab_ssh
Jan 22, 2021
Merged

Allows GitLab SSH URLs on pack actions#5050
amanda11 merged 11 commits intoStackStorm:masterfrom
lcsaa:allow_gitlab_ssh

Conversation

@lcsaa
Copy link
Contributor

@lcsaa lcsaa commented Oct 1, 2020 •
edited
Loading

Previously only GitHub based URL could be used for downloading and installing packs. This PR allows GitLab SSH URLs.

@pull-request-size pull-request-size bot added the size/XS PR that changes 0-9 lines. Quick fix/merge. label Oct 1, 2020
@CLAassistant
Copy link

CLAassistant commented Oct 1, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

nmaludy
nmaludy suggested changes Oct 1, 2020
View reviewed changes
Copy link
Member

@nmaludy nmaludy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asthLucas Thanks a ton for the PR, this looks good!

Would you mind please adding an entry into CHANGELOG.rst ?

It also might help to add a PR to the https://github.com/StackStorm/st2docs repo so that others know that gitlab URLs can be used.

Thanks again!

@lcsaa lcsaa changed the title Allows GitLab SSH URL on pack actions Allows GitLab SSH URLs on pack actions Oct 2, 2020
@pull-request-size pull-request-size bot added size/S PR that changes 10-29 lines. Very easy to review. and removed size/XS PR that changes 0-9 lines. Quick fix/merge. labels Oct 2, 2020
@lcsaa
Copy link
Contributor Author

lcsaa commented Oct 2, 2020 •
edited
Loading

@nmaludy Thanks for the advice.

I`ve updated the changelog and the documentation on st2docs.

@nmaludy nmaludy added this to the 3.4.0 milestone Oct 5, 2020
nmaludy
nmaludy approved these changes Oct 5, 2020
View reviewed changes
Copy link
Member

@nmaludy nmaludy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asthLucas Thanks for these changes, i'm approving them now but targeting them for the 3.4.0 release, 3.3.0 is change freeze tomorrow and i don't want to introduce any new changes before then.

@blag
Copy link
Contributor

blag commented Jan 21, 2021

I'm going to make this a blocker for v3.4 to ensure that it makes it in. I'll be working on fixing the end-to-end tests and rerunning them today.

@amanda11 amanda11 merged commit 3a87a73 into StackStorm:master Jan 22, 2021
@arm4b arm4b mentioned this pull request Feb 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nmaludy nmaludy nmaludy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/S PR that changes 10-29 lines. Very easy to review.

Projects

None yet

Milestone

3.4.0

Development

Successfully merging this pull request may close these issues.

6 participants

@lcsaa @CLAassistant @blag @nmaludy @amanda11 @arm4b