Rollback field changes on workflow and task execution collection#4875
Merged
Rollback field changes on workflow and task execution collection#4875
Conversation
Rollback fields from DictField to EscapedDictField because in various use cases, result may contain dictionary which IP address as key. DictField does not allow "." in the key name. The execution result may be published into the context and into workflow output and then passed as input into subworkflow. Appropriate fields are rolled back to EscapedDictField to avoid breaking existing user workflows.
A test orquesta workflow is refactored to use a python action to return specific result. The use of the python action from the examples pack requires the virtualenv for the examples pack to be setup.
arm4b
approved these changes
Feb 25, 2020
Member
arm4b
left a comment
There was a problem hiding this comment.
👍
Considering it fixes the builds.
Contributor
|
I'm glad we caught this before any users found it. 👍 |
Contributor
|
Rolls back part of #4854. |
Contributor
|
Related: #4892. |
punkrokk
added a commit
that referenced
this pull request
Jun 26, 2020
punkrokk
pushed a commit
that referenced
this pull request
Jul 16, 2020
…_sooner Fixes: #4875 monkeypatch st2 sensor earlier
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rollback fields from DictField to EscapedDictField because in various use cases, result may contain dictionary which IP address as key. DictField does not allow "." in the key name. The execution result may be published into the context and into workflow output and then passed as input into subworkflow. Appropriate fields are rolled back to EscapedDictField to avoid breaking existing user workflows.