Install pack with the latest tag by jinpingh · Pull Request #4743 · StackStorm/st2

jinpingh · 2019-07-16T17:40:18Z

First part of Fixes StackStorm/discussions#354.
If pack version is not specified, install the latest version from pack index.json (https://index.stackstorm.org/v1/index.json), otherwise install from master branch as today.
Note: Direct github/repo install is not considered an Exchange index hit, therefore it is not covert by this fix.

Closes #4384

m4dcoder · 2019-07-16T17:43:46Z

Have you actually test this change on a pack at GitHub with a tag? If so, can you post the output here? Thanks.

CHANGELOG.rst

arm4b · 2019-07-16T17:47:10Z

Also closes #4384 (#4384 (comment))

jinpingh · 2019-07-16T17:52:08Z

Have you actually test this change on a pack at GitHub with a tag?

Yes.

m4dcoder · 2019-07-16T18:01:51Z

@jinpingh Can you post the output here for test against a real pack? Thanks.

st2common/st2common/util/pack_management.py

CHANGELOG.rst

jinpingh · 2019-07-16T22:56:12Z

(virtualenv) vagrant@ubuntu-xenial:/opt/stackstorm/packs/jira$ st2 pack install digitalocean

For the "digitalocean" pack, the following content will be registered:

rules     |  0
sensors   |  0
triggers  |  0
actions   |  14
aliases   |  0

Installation may take a while for packs with many items.

        [ succeeded ] download pack
        [ succeeded ] make a prerun
        [ succeeded ] install pack dependencies
        [ succeeded ] register pack

+-------------+--------------------------------------------------------+
| Property    | Value                                                  |
+-------------+--------------------------------------------------------+
| name        | Digital Ocean                                          |
| description | st2 content pack containing Digital Ocean integration. |
| version     | 0.3.2                                                  |
| author      | StackStorm, Inc.                                       |
+-------------+--------------------------------------------------------+

(virtualenv) vagrant@ubuntu-xenial:/opt/stackstorm/packs/digitalocean$ git log
commit fe5af6713d6eeb85ad290b1132df214f0c2f85f8
Author: Kirill Izotov <enykeev@stackstorm.com>
Date:   Fri Oct 27 14:55:05 2017 +0700

    Remove deprecated st2actions import

commit 154f3c63e7f4d9de7db631fc604e195a330ec7e9
Merge: 5459ac3 f5dc8a1
Author: Tomaz Muraus <tomaz@tomaz.me>
Date:   Mon Jul 17 07:40:46 2017 +0200

    Merge pull request #3 from nmaludy/master

    Convert results from digitalocean objects to dicts and lists

st2common/st2common/util/pack_management.py

CHANGELOG.rst

First part of Fixes StackStorm/discussions#354. If pack version is not specified, install the latest version from pack index.json (https://index.stackstorm.org/v1/index.json), otherwise install from master branch as today. Note: Direct github/repo install is not considered an Exchange index hit, therefore it is not covert by this fix.

contrib/packs/tests/test_action_download.py

Root cause: Value passed to arg_ref for `fake_commit` is `v0.4.0` after new code changes, but local `ref` is None. So it failed comparison at line https://github.com/StackStorm/st2/blob/c0458f1a06c2a81cac81697817c422ffb7631047/contrib/packs/tests/test_action_download.py#L523 and mocked `gitref` value is not returned.

arm4b

Good work on finding the exact place for this change and fixing the old tests 👍

Please include a new dedicated test case that would cover and verify new behavior exclusively: st2 pack install will install latest stable release version/tag, taken from exchange index.

contrib/packs/tests/test_action_download.py

arm4b

Looks good 👍

Thanks for changes made!

With new improvement code StackStorm/st2#4743, if pack version is not provided, the latest version for pack from index.json is installed. Modify existing `e2e` test to check: 1. Install pack without version and check if the latest version for pack from index.json is installed. 2) install pack with version and check if the version specified is the version installed.

With new improvement code StackStorm/st2#4743, if pack version is not provided, the latest version for pack from index.json is installed. Modify existing `e2e` test `tests.test_run_pack_tests_tool` to check: 1. Install pack without version and check if the latest version for pack from index.json is installed. `st2 pack install csv` 2) install pack with version and check if the version specified is the version installed. `st2 pack install xml=0.3.0

With new improvement code StackStorm/st2#4743, if pack version is not provided, the latest version for pack from index.json is installed. Part of Fixes: https://github.com/StackStorm/discussions/issues/354 Modify existing `e2e` test `tests.test_run_pack_tests_tool` to check: 1. Install pack without version and check if the latest version for pack from index.json is installed. `st2 pack install csv` 2) install pack with version and check if the version specified is the version installed. `st2 pack install xml=0.3.0

See #973 and StackStorm/st2#4743

arm4b reviewed Jul 16, 2019

View reviewed changes

CHANGELOG.rst Show resolved Hide resolved

arm4b added this to the 3.2.0 milestone Jul 16, 2019

arm4b reviewed Jul 16, 2019

View reviewed changes

st2common/st2common/util/pack_management.py Outdated Show resolved Hide resolved

arm4b reviewed Jul 16, 2019

View reviewed changes

CHANGELOG.rst Outdated Show resolved Hide resolved

arm4b suggested changes Jul 16, 2019

View reviewed changes

st2common/st2common/util/pack_management.py Outdated Show resolved Hide resolved

arm4b reviewed Jul 17, 2019

View reviewed changes

CHANGELOG.rst Outdated Show resolved Hide resolved

arm4b reviewed Jul 17, 2019

View reviewed changes

CHANGELOG.rst Outdated Show resolved Hide resolved

jinpingh mentioned this pull request Jul 17, 2019

Bump up version to fix pack index version issue StackStorm-Exchange/stackstorm-csv#11

Merged

jinpingh force-pushed the issue-354/install-pack-latest-tag branch from a363763 to c50c8c6 Compare July 18, 2019 18:05

jinpingh force-pushed the issue-354/install-pack-latest-tag branch from c50c8c6 to 429e986 Compare July 18, 2019 18:16

arm4b reviewed Jul 18, 2019

View reviewed changes

contrib/packs/tests/test_action_download.py Outdated Show resolved Hide resolved

arm4b added the enhancement label Jul 19, 2019

arm4b suggested changes Jul 22, 2019

View reviewed changes

New dedicated test case for checkout latest tag

219c9a2

jinpingh force-pushed the issue-354/install-pack-latest-tag branch from 26ab318 to 219c9a2 Compare July 23, 2019 00:42

arm4b reviewed Jul 23, 2019

View reviewed changes

contrib/packs/tests/test_action_download.py Show resolved Hide resolved

Better way to handle mock_get_gitref return value

8547e1c

st2stanley approved these changes Jul 23, 2019 •

edited

Loading

View reviewed changes

arm4b approved these changes Jul 23, 2019

View reviewed changes

jinpingh merged commit a68a6bf into master Jul 23, 2019

jinpingh deleted the issue-354/install-pack-latest-tag branch July 23, 2019 19:04

jinpingh mentioned this pull request Jul 26, 2019

Check installed pack version as expected StackStorm/st2tests#176

Merged

This was referenced Apr 17, 2020

StackStorm v3.2dev pre-release Testing StackStorm/community#6

Closed

Update pack documentation to state it uses last pack version/release StackStorm/st2docs#973

Merged

arm4b pushed a commit to StackStorm/st2docs that referenced this pull request Apr 21, 2020

Add a note about 'st2 pack install' behavior changes for v3.2

64523e3

See #973 and StackStorm/st2#4743

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Install pack with the latest tag#4743

Install pack with the latest tag#4743
jinpingh merged 4 commits intomasterfrom
issue-354/install-pack-latest-tag

jinpingh commented Jul 16, 2019 •

edited

Loading

Uh oh!

m4dcoder commented Jul 16, 2019 •

edited

Loading

Uh oh!

Uh oh!

arm4b commented Jul 16, 2019 •

edited

Loading

Uh oh!

jinpingh commented Jul 16, 2019

Uh oh!

m4dcoder commented Jul 16, 2019

Uh oh!

Uh oh!

Uh oh!

jinpingh commented Jul 16, 2019 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

arm4b left a comment •

edited

Loading

Uh oh!

Uh oh!

arm4b left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

jinpingh commented Jul 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

m4dcoder commented Jul 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

arm4b commented Jul 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jinpingh commented Jul 16, 2019

Uh oh!

m4dcoder commented Jul 16, 2019

Uh oh!

Uh oh!

Uh oh!

jinpingh commented Jul 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

arm4b left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

arm4b left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jinpingh commented Jul 16, 2019 •

edited

Loading

m4dcoder commented Jul 16, 2019 •

edited

Loading

arm4b commented Jul 16, 2019 •

edited

Loading

jinpingh commented Jul 16, 2019 •

edited

Loading

arm4b left a comment •

edited

Loading