Merged
Conversation
…stalled on older OSes
amanda11
reviewed
Feb 15, 2021
amanda11
left a comment
There was a problem hiding this comment.
In general looks good, but added some comments about equivalence with other installers, and also the RH problem of the python36-devel not being in EPEL.
I'd appreciate another set of eyes, as not too familiar with Puppet these days.
704c426 to
1fb2a35
Compare
amanda11
reviewed
Feb 15, 2021
amanda11
left a comment
There was a problem hiding this comment.
LGTM - just suggestion to call out the security warnings in the PPA like we do on the other installers. We had explicit warning, link to the warning on the dead snakes page and an upgrade suggestion.
bishopbm1
pushed a commit
to EncoreTechnologies/puppet-st2
that referenced
this pull request
May 20, 2022
Feature/python3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows specifying a python version to install/
Example:
We default to installing/using the
systempython, but users can opt-in to installing non-system versions if they like.