Remove tags from system package dependencies#323
Merged
Conversation
arm4b
reviewed
Dec 2, 2020
Co-authored-by: Eugen Cusmaunsa <stackstorm@armab.io>
bishopbm1
pushed a commit
to EncoreTechnologies/puppet-st2
that referenced
this pull request
May 20, 2022
Remove tags from system package dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the system dependencies for the auth packages had tags declared. These tags were not used. It caused issues with things such as
gccwhen other modules would try to declare these packages, the declarations would conflict because thePackage[gcc]declaration in the other modules wouldn't include the StackStorm tags.Since these tags are unused, i simply removed them!