Merged
Conversation
660f2ac to
fe57d1f
Compare
|
LGTM but would like someone else to review. Some queries:
|
25 tasks
Member
Author
|
@amanda11 i removed the fact and yes the postgresql reference is still valid there, it's more about module architecture rather than using postgresql itself. Thanks for the review! |
…ral' into feature/remove-mistral
ea8bb9a to
2578817
Compare
bishopbm1
pushed a commit
to EncoreTechnologies/puppet-st2
that referenced
this pull request
May 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #312
Removes Mistral and PostgreSQL.
I also updated the build dependencies now that we removed some modules.