Skip to content

Added support for RabbitMQ auth along with additional config options#248

Merged
nmaludy merged 9 commits intomasterfrom
feature/rabbitmq-auth
Nov 27, 2018
Merged

Added support for RabbitMQ auth along with additional config options#248
nmaludy merged 9 commits intomasterfrom
feature/rabbitmq-auth

Conversation

@nmaludy
Copy link
Member

@nmaludy nmaludy commented Sep 23, 2018

Closes #247

Changes:

  • Remove the RabbitMQ default guest user
  • Added support for RabbitMQ authentication that is enabled by default (uses st2admin as default)
  • Added additional options for configuring RabbitMQ such as bind_ip, hostname, port, vhost. This should allow for users to connect to external RabbitMQ instances.
  • Set default checks in unit testing scripts (for my sanity)
  • Enhancements to the Makefile so i can clean up the junk that tests output
  • Enhancements to ci script so i can run it locally and have it "just work"

@nmaludy nmaludy self-assigned this Sep 23, 2018
@nmaludy nmaludy requested a review from arm4b September 23, 2018 01:39
@nmaludy
Copy link
Member Author

nmaludy commented Sep 23, 2018

Closes #232


# URL encode the RabbitMQ password, in case it contains special characters that
# can mess up the URL.
$_rabbitmq_pass = st2::urlencode($rabbitmq_password)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nmaludy nmaludy merged commit 316d0d8 into master Nov 27, 2018
@nmaludy nmaludy deleted the feature/rabbitmq-auth branch November 27, 2018 02:19
bishopbm1 pushed a commit to EncoreTechnologies/puppet-st2 that referenced this pull request May 20, 2022
Added support for RabbitMQ auth along with additional config options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants