Skip to content

Added st2timersengine service#246

Merged
nmaludy merged 3 commits intomasterfrom
feature/timersengine
Sep 22, 2018
Merged

Added st2timersengine service#246
nmaludy merged 3 commits intomasterfrom
feature/timersengine

Conversation

@nmaludy
Copy link
Member

@nmaludy nmaludy commented Sep 22, 2018

Closes #221

  • Adds support for new st2timersengine service in 2.9.0
  • Fixes the redirect InSpec tests for Debian to look for HTTP 308 instead of 301

@nmaludy nmaludy requested a review from arm4b September 22, 2018 00:00
end
elsif os.redhat?
# on RHEL nginx redirects to https and returns 200
# on RHEL nginx automatically redirects to https and returns 200
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this different result caused by different http client behavior or it's really nginx?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really think it's nginx. I tried it on my local install using the 1-liner and it did the same thing... Very odd, I know.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was using cURL on both

@nmaludy
Copy link
Member Author

nmaludy commented Sep 22, 2018

Added a fix for StackStorm/st2#4358

Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nmaludy nmaludy merged commit 691b28b into master Sep 22, 2018
@nmaludy nmaludy deleted the feature/timersengine branch September 22, 2018 23:43
bishopbm1 pushed a commit to EncoreTechnologies/puppet-st2 that referenced this pull request May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants