Skip to content

allow auth with user (redis 6)#1410

Merged
mgravell merged 1 commit intomasterfrom
marc/auth6
Mar 30, 2020
Merged

allow auth with user (redis 6)#1410
mgravell merged 1 commit intomasterfrom
marc/auth6

Conversation

@mgravell
Copy link
Copy Markdown
Collaborator

@mgravell mgravell commented Mar 28, 2020 •
edited
Loading

  • adds new config options for cn+pw authentication against redis 6
  • currently no inbuilt test, because we need to figure out a redis 6 testing setup
  • no support for extended ACL command set yet
    1. because they aren't entirely nailed down yet, and
    2. because they aren't critical path to being able to use it, because
    3. everything still works fine via all-encompassing Execute fallback

@mgravell mgravell requested a review from NickCraver March 28, 2020 11:56
@NickCraver
Copy link
Copy Markdown
Collaborator

NickCraver commented Mar 28, 2020

For local, you can change the 5 to a 6 in the tests\RedisConfigs\Dockerfile up top to quickly get a 6.x (5.9 really) running:

- FROM redis:5
+ FROM redis:6.0-rc

To rebuild:

docker-compose build --no-cache
docker-compose up

@NickCraver
Copy link
Copy Markdown
Collaborator

NickCraver commented Mar 28, 2020

FWIW Did a quick run against local docker 6 as above: dotnet test .\Build.csproj -c Release and only had 1 flaky failure...6 is looking good. Probably viable to kick it up.

@mgravell mgravell merged commit 84bce91 into master Mar 30, 2020
@IAmATeaPot418 IAmATeaPot418 mentioned this pull request Apr 1, 2020
Closed
odinserj added a commit to HangfireIO/StackExchange.Redis that referenced this pull request Sep 15, 2020
@odinserj
Allow to pass username to AUTH command available in Redis 6
3f09e40 
From StackExchange#1410
@NickCraver NickCraver deleted the marc/auth6 branch May 23, 2021 17:23
@BrennanConroy BrennanConroy mentioned this pull request Jan 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NickCraver NickCraver Awaiting requested review from NickCraver

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mgravell @NickCraver