Conversation
| args.Add("SCORER".Literal()); | ||
| args.Add(Scoring); | ||
|
|
||
| if (ExplainScore) |
There was a problem hiding this comment.
@jjchiw EXPLAINSCORE should stand on its own and is not only limited to cases where SCORER is used
There was a problem hiding this comment.
I think EXPLAINSCORE literal it depends on SCORER (https://oss.redislabs.com/redisearch/Commands.html#ftsearch)
FT.SEARCH {index} {query} [NOCONTENT] [VERBATIM] [NOSTOPWORDS] [WITHSCORES] [WITHPAYLOADS] [WITHSORTKEYS]
[FILTER {numeric_field} {min} {max}] ...
[GEOFILTER {geo_field} {lon} {lat} {radius} m|km|mi|ft]
[INKEYS {num} {key} ... ]
[INFIELDS {num} {field} ... ]
[RETURN {num} {field} ... ]
[SUMMARIZE [FIELDS {num} {field} ... ] [FRAGS {num}] [LEN {fragsize}] [SEPARATOR {separator}]]
[HIGHLIGHT [FIELDS {num} {field} ... ] [TAGS {open} {close}]]
[SLOP {slop}] [INORDER]
[LANGUAGE {language}]
[EXPANDER {expander}]
[SCORER {scorer}] [EXPLAINSCORE]
[PAYLOAD {payload}]
[SORTBY {field} [ASC|DESC]]
[LIMIT offset num]
| Assert.Contains("", args); | ||
| Assert.Contains("SCORER".Literal(), args); | ||
| Assert.Contains("TFIDF.DOCNORM", args); | ||
| Assert.Contains("EXPLAINSCORE".Literal(), args); |
There was a problem hiding this comment.
@jjchiw I think you should also add a test that runs a Search with EXPLAINSCORE and validate the result
There was a problem hiding this comment.
Done :)
Here: tests/NRediSearch.Test/ExampleUsage.cs
https://github.com/StackExchange/StackExchange.Redis/pull/1254/files#diff-5f7cf341c5a99b172f218d160f44864dR79
|
Sure... I'll check it out during the week... |
|
There are two tests that are failing, I think it's because of the redis version
|
|
Fair enough. I'll look into those - I thought those had been fixed, but
yes: there's some minor error copy changes that have crept in between
versions.
…On Sun, 9 Feb 2020, 20:38 jjchiw, ***@***.***> wrote:
There are two tests that are failing, I think it's because of the redis
version
[image: image]
<https://user-images.githubusercontent.com/642319/74109503-4abeb580-4b84-11ea-9c7e-61dc58cfc2d8.png>
[image: image]
<https://user-images.githubusercontent.com/642319/74109507-54481d80-4b84-11ea-9f5e-49887f4dd39d.png>
# Server
redis_version:5.0.7
redis_git_sha1:00000000
redis_git_dirty:0
redis_build_id:9d06145e39725623
redis_mode:standalone
os:Linux 4.19.76-linuxkit x86_64
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1254?email_source=notifications&email_token=AAAEHMBNXO7CFUPHSG6GTOTRCBSTNA5CNFSM4JBRVP6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELGXMDA#issuecomment-583890444>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAEHMBAR56YIJWETCVNYUTRCBSTNANCNFSM4JBRVP6A>
.
|
|
This is looking great; just as a double-check, can I confirm that you're able and willing (and thus: doing so) to freely contribute this code to the project under the project's license? |
|
Yes, I am willing to freely contribute this code to the project under the projec'ts license. :) |
|
Merging, thanks; I'll get this added to the 2.1 release notes |
#1251
Scoring in RediSearch
Allow to set scoring (pre-bundled scoring function)