Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: StackExchange/StackExchange.Redis
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.1.0
Choose a base ref
...
head repository: StackExchange/StackExchange.Redis
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.1.30
Choose a head ref
  • 18 commits
  • 37 files changed
  • 5 contributors

Commits on Mar 21, 2020

  1. Actions! Let's see if we can make this merry-go-round spin. (#1398)

    Billing issues have cleared on the org - taking a stab at this.
    
    First attempt: let's get a Linux CI going.
    NickCraver authored Mar 21, 2020
    Configuration menu
    Copy the full SHA
    2090d7d View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2020

  1. Fix up boadcasts, tests, and logging across the board (#1400)

    This changes does the following:
    - Moves the broadcast to be only before the master reconfiguration to both before *and* after - a fix following 88dcf0c to fix the gap.
    - Tweaks tests by overall lessening runtime (and thus build server time). Overall, fixes a few static timeouts to be conditional (so they short circuit faster if met), and brings some tests that were some variant of the above into RELEASE since they're safe now.
    - Changes `UntilCondition` to take a `TimeSpan`, just because clearer. Even though I IntelliSense completed `.FromMinutes()` earlier and watched it like an idiot for a while...I stand by this decision!
    - Locks the `ITestOutputHelper` writer because...that was jacked up in races:
    
    ![off to the races](https://user-images.githubusercontent.com/454813/77232395-2f799980-6b77-11ea-8fb4-0398de25e313.png)
    
    ------
    
    Note: a lot of the test changes are just optimizations to delays which allow longer but short-circuit sooner. The important changes are in broadcast and locking around the test runner. I can think of downsides to neither, but want some @mgravell eyes. This should resolve a lot of flaky-ness with local (and build agent) tests. Not all of it, but a lot of it!
    NickCraver authored Mar 23, 2020
    Configuration menu
    Copy the full SHA
    b90f991 View commit details
    Browse the repository at this point in the history
  2. Message clarification for #1287 (#1396)

    Old message:
    > To create a disconnected multiplexer, disable AbortOnConnectFail.
    
    New message proposal:
    > Error connecting right now. To allow this multiplexer to continue retrying until it's able to connect, use abortConnect=false in your connection string or AbortOnConnectFail=false; in your code.
    NickCraver authored Mar 23, 2020
    Configuration menu
    Copy the full SHA
    2ab9b37 View commit details
    Browse the repository at this point in the history
  3. Better Connection Counts & Error Messages (#1397)

    * ConnectionMultiplexer: track global counts for deebugging
    
    * Build dammit
    
    * Move to per-multiplexer/add tests
    
    Note: I know mutiplexer isn't spelled right - will fix that in a follow-up to avoid noise.
    
    * Fix test key names
    
    Broken since the 2.1 bump, oops
    
    * Simplify the NoConnectionAvailable static
    
    Simpifies usage for all callers. Also shares code and adds diagnostics to the "no connection" case.
    
    * Add tests for NoConnectionException
    
    * Failover: fix tests and debug some
    
    SubscriptionsSurviveMasterSwitchAsync is a thorn in our side - moving to DEBUG.
    
    * Remove bad check
    
    Inner is irrelevant here - can be not-null depending on the connection race.
    
    * Update message and add more tests!
    
    * Bump pipelines to 2.1.6
    NickCraver authored Mar 23, 2020
    Configuration menu
    Copy the full SHA
    a01cd04 View commit details
    Browse the repository at this point in the history
  4. Fix null ref in Sentinel

    Nick Craver committed Mar 23, 2020
    1 Configuration menu
    Copy the full SHA
    46be338 View commit details
    Browse the repository at this point in the history
  5. Sentinel: Several break fixes (#1402)

    * fix naming of SentinelGetSentinelAddressesAsync
    
    * tyop
    
    * Sentinel: don't use async over sync with .Result
    
    Co-authored-by: mgravell <marc.gravell@gmail.com>
    NickCraver and mgravell authored Mar 23, 2020
    Configuration menu
    Copy the full SHA
    49f24a2 View commit details
    Browse the repository at this point in the history
  6. fix plinq glitch

    mgravell committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    1dcf55e View commit details
    Browse the repository at this point in the history
  7. Tweak versioning

    Nick Craver committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    531ffa4 View commit details
    Browse the repository at this point in the history
  8. FirstOrDefault love for Sentinel

    Nick Craver committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    63bbcde View commit details
    Browse the repository at this point in the history
  9. Move Issue922_ReconnectRaised to DEBUG

    Nick Craver committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    c3bc13d View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2020

  1. Sentinel: remove Thread.Sleep and throws (#1403)

    We were throwing in event handlers...that's not good. Also post-thread sleep in timer callbacks.
    NickCraver authored Mar 25, 2020
    Configuration menu
    Copy the full SHA
    fc8dcde View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2020

  1. Including SslProtocols in ConfigurationOptions.ToString() (#1408)

    * Including SslProtocols in ConfigurationOptions.ToString()
    
    * Removing an unnecessary method and making the code concise (based on code review comments)
    
    Co-authored-by: Sampath Vuyyuru <sampath.vuyyuru@kincentric.com>
    vksampath and Sampath Vuyyuru authored Mar 27, 2020
    Configuration menu
    Copy the full SHA
    6b20e13 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2020

  1. Configuration menu
    Copy the full SHA
    8349c04 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    84bce91 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    06fd156 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e12c612 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2020

  1. fix build to get green shields for Source Link and Deterministic (#1420)

    fix build to get green shields for Source Link and Deterministic
    mgravell authored Apr 5, 2020
    Configuration menu
    Copy the full SHA
    eb97dc1 View commit details
    Browse the repository at this point in the history
  2. release notes

    mgravell committed Apr 5, 2020
    Configuration menu
    Copy the full SHA
    5c3036a View commit details
    Browse the repository at this point in the history
Loading