Conversation
Owner
Author
|
@MattMills Could you try this PR to see if it works well? |
|
Rebuilt with the new signatures and seems to work great, thanks! |
|
@SpriteOvO just incase you didn't see those comments on this PR ^ |
Owner
Author
I recently moved to a new place physically, and my PC is still on the way, I will merge it after my PC is setup :) |
920a4da to
74c55a0
Compare
SpriteOvO
added a commit
that referenced
this pull request
Aug 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements Ghidra signature format as a experimental feature requested in #2.
Since there is no documentation for this format at the moment, the implementation is referred to NationalSecurityAgency/ghidra#5490 (comment) - The binary sequence of one byte is enclosed in square brackets, and
.will be treated as a wildcard.To use this experimental feature, define the configuration macro
SIGMATCH_EXPERIMENTAL_ENABLE_GHIDRA_SIGNATURE_FORMATbefore includingsigmatch.hpp.Breaking changes:
enum class byte_match_modehas been removed.sig_byte::match_mode()has been removed.New public items:
sig_byte::sig_byte(std::byte value, std::byte mask)andsig_byte::sig_byte(unsigned char value, unsigned char mask)is added.sig_byte::value()andsig_byte::mask()is added.