fix #9: QR-codes consisting of numerics only are failed to scan#10
Merged
Spelt merged 1 commit intoSpelt:masterfrom Mar 2, 2016
Merged
fix #9: QR-codes consisting of numerics only are failed to scan#10Spelt merged 1 commit intoSpelt:masterfrom
Spelt merged 1 commit intoSpelt:masterfrom
Conversation
QR-code for numeric-only (e.g. "12" string http://qrcoder.ru/code/?12&10&0) is not recognized with the test app. Unit-test for this image causes AV. The reason is in TDecoderResult.Destroy calls ByteSegments.Clear without testing ByteSegments for nil. But ByteSegments is nil when QR-code is numeric only. Fix is to test ByteSegments for nil before calling ByteSegments.Clear. Known issues: numerics of one digit is not still recognized. Signed-off-by: Alexey Shumkin <Alex.Crezoff@gmail.com>
Spelt
added a commit
that referenced
this pull request
Mar 2, 2016
fix #9: QR-codes consisting of numerics only are failed to scan
Owner
|
Thank! |
Spelt
pushed a commit
that referenced
this pull request
Dec 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QR-code for numeric-only (e.g. "12" string http://qrcoder.ru/code/?12&10&0)
is not recognized with the test app.
Unit-test for this image causes AV.
The reason is in TDecoderResult.Destroy calls ByteSegments.Clear without
testing ByteSegments for nil. But ByteSegments is nil when QR-code is
numeric only.
Fix is to test ByteSegments for nil before calling ByteSegments.Clear.
Known issues: numerics of one digit is not still recognized.
Signed-off-by: Alexey Shumkin Alex.Crezoff@gmail.com